Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save unknown update #431

Merged
merged 3 commits into from
Sep 28, 2018
Merged

Conversation

stewartjarod
Copy link
Contributor

@stewartjarod stewartjarod commented Sep 28, 2018

Summary:

Fixing issue with Model Updates with unknown attributes

GitHub linked issue:

#403

Other information:

Type (select 1):

  • Bug fix
  • Feature implementation
  • Documentation improvement
  • Testing improvement
  • Test added to report bug (GitHub issue #--- @---)
  • Something not listed here

Is this a breaking change? (select 1):

  • 馃毃 YES 馃毃
  • No
  • I'm not sure

Is this ready to be merged into Dynamoose? (select 1):

  • Yes
  • No

Are all the tests currently passing on this PR? (select 1):

  • Yes
  • No

Other:

  • I have searched through the GitHub pull requests to ensure this PR has not already been submitted
  • I have updated the Dynamoose documentation (if required) given the changes I made
  • I have added/updated the Dynamoose test cases (if required) given the changes I made
  • I have run npm test from the root of the project directory to ensure all tests continue to pass
  • I agree that all changes made in this pull request may be distributed and are made available in accordance with the Dynamoose license
  • All of my commits and commit messages are detailed, explain what changes were made, and are easy to follow and understand
  • I have confirmed that all my code changes are indented properly using 2 spaces
  • I have filled out all fields above

@stewartjarod
Copy link
Contributor Author

@fishcharlie Think we can get this in soon?

@coveralls
Copy link

coveralls commented Sep 28, 2018

Pull Request Test Coverage Report for Build 658

  • 13 of 18 (72.22%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 84.577%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/Model.js 13 18 72.22%
Totals Coverage Status
Change from base Build 654: -0.02%
Covered Lines: 1855
Relevant Lines: 2119

馃挍 - Coveralls

@fishcharlie fishcharlie merged commit 41474d0 into dynamoose:master Sep 28, 2018
@fishcharlie
Copy link
Member

@stewartjarod Let's do it!! 馃槂

@fishcharlie fishcharlie added this to the v1.0 milestone Sep 28, 2018
@stewartjarod stewartjarod deleted the saveUnknownUpdate branch September 28, 2018 20:55
This was referenced Sep 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants