Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

DynamoDB On-Demand Support #471

Merged
merged 4 commits into from Nov 30, 2018
Merged

DynamoDB On-Demand Support #471

merged 4 commits into from Nov 30, 2018

Conversation

fishcharlie
Copy link
Member

Summary:

This PR adds an option for ON_DEMAND for throughput for your schema to create the table using PAY_PER_REQUEST Billing Mode.

Code sample:

Schema

var User = new dynamoose.Schema({
  id: Number,
  name: String
}, {
  throughput: "ON_DEMAND"
});

GitHub linked issue:

Closes #470

Other information:

  • Currently DynamoDB Local doesn't support the BillingMode property. Once support for that is added, we need to update this code. I have added comments for changes needed once that support is added.

Type (select 1):

  • Bug fix
  • Feature implementation
  • Documentation improvement
  • Testing improvement
  • Test added to report bug (GitHub issue #--- @---)
  • Something not listed here

Is this a breaking change? (select 1):

  • 馃毃 YES 馃毃
  • No
  • I'm not sure

Is this ready to be merged into Dynamoose? (select 1):

  • Yes
  • No

Are all the tests currently passing on this PR? (select 1):

  • Yes
  • No

Other:

  • I have searched through the GitHub pull requests to ensure this PR has not already been submitted
  • I have updated the Dynamoose documentation (if required) given the changes I made
  • I have added/updated the Dynamoose test cases (if required) given the changes I made
  • I have run npm test from the root of the project directory to ensure all tests continue to pass
  • I agree that all changes made in this pull request may be distributed and are made available in accordance with the Dynamoose license
  • All of my commits and commit messages are detailed, explain what changes were made, and are easy to follow and understand
  • I have confirmed that all my code changes are indented properly using 2 spaces
  • I have filled out all fields above

@coveralls
Copy link

coveralls commented Nov 29, 2018

Pull Request Test Coverage Report for Build 729

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 85.192%

Totals Coverage Status
Change from base Build 726: 0.2%
Covered Lines: 1887
Relevant Lines: 2146

馃挍 - Coveralls

@fishcharlie fishcharlie merged commit 6f39b24 into dynamoose:master Nov 30, 2018
@fishcharlie fishcharlie deleted the ddbondemandsupport branch November 30, 2018 20:42
@fishcharlie fishcharlie mentioned this pull request Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DynamoDB On-Demand Support
3 participants