Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return LastKey when using RAW Scan #475

Merged
merged 2 commits into from Dec 1, 2018
Merged

Return LastKey when using RAW Scan #475

merged 2 commits into from Dec 1, 2018

Conversation

fishcharlie
Copy link
Member

Summary:

This PR fixes a bug where the last key wouldn't be returned if doing a raw scan.

GitHub linked issue:

Closes #474

Type (select 1):

  • Bug fix
  • Feature implementation
  • Documentation improvement
  • Testing improvement
  • Test added to report bug (GitHub issue #--- @---)
  • Something not listed here

Is this a breaking change? (select 1):

  • 馃毃 YES 馃毃
  • No
  • I'm not sure

Is this ready to be merged into Dynamoose? (select 1):

  • Yes
  • No

Are all the tests currently passing on this PR? (select 1):

  • Yes
  • No

Other:

  • I have searched through the GitHub pull requests to ensure this PR has not already been submitted
  • I have updated the Dynamoose documentation (if required) given the changes I made
  • I have added/updated the Dynamoose test cases (if required) given the changes I made
  • I have run npm test from the root of the project directory to ensure all tests continue to pass
  • I agree that all changes made in this pull request may be distributed and are made available in accordance with the Dynamoose license
  • All of my commits and commit messages are detailed, explain what changes were made, and are easy to follow and understand
  • I have confirmed that all my code changes are indented properly using 2 spaces
  • I have filled out all fields above

@coveralls
Copy link

Pull Request Test Coverage Report for Build 736

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 85.204%

Totals Coverage Status
Change from base Build 726: 0.2%
Covered Lines: 1885
Relevant Lines: 2144

馃挍 - Coveralls

Copy link
Contributor

@jutaz jutaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMG, yes! I found out about this not being returned the hard way. Thanks for the fix 馃檶

@fishcharlie
Copy link
Member Author

@jutaz Awesome! Will merge right before #464. Wanna try to give @vincentkwok as much time to review as possible.

@fishcharlie fishcharlie mentioned this pull request Nov 30, 2018
@fishcharlie fishcharlie merged commit acca786 into dynamoose:master Dec 1, 2018
@fishcharlie fishcharlie deleted the scanRawLastKeyFix branch December 1, 2018 01:55
@vincentkwok
Copy link

Great thanks

@fishcharlie
Copy link
Member Author

@vincentkwok Of course!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing lastKey for scan filter expresion
4 participants