Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamoose.d.ts allow validate property on schema to return promise as well as raw boolean #520

Merged
merged 1 commit into from Jan 3, 2019

Conversation

qisaw
Copy link
Contributor

@qisaw qisaw commented Dec 31, 2018

Summary:

This PR is a type definition tweak.
The dynamoose validate expression allows you to return a promise that resolves to a boolean, ranther than just a boolean.

I added this to the type definition of the validate property on SchemaAttributeDefinition

Type (select 1):

  • Bug fix
  • Feature implementation
  • Documentation improvement
  • Testing improvement
  • Test added to report bug (GitHub issue #--- @---)
  • Something not listed here

Is this a breaking change? (select 1):

  • 馃毃 YES 馃毃
  • No
  • I'm not sure

Is this ready to be merged into Dynamoose? (select 1):

  • Yes
  • No

Are all the tests currently passing on this PR? (select 1):

  • Yes
  • No

Other:

  • I have searched through the GitHub pull requests to ensure this PR has not already been submitted
  • I have updated the Dynamoose documentation (if required) given the changes I made
  • I have added/updated the Dynamoose test cases (if required) given the changes I made
  • I have run npm test from the root of the project directory to ensure all tests continue to pass
  • I agree that all changes made in this pull request may be distributed and are made available in accordance with the Dynamoose license
  • All of my commits and commit messages are detailed, explain what changes were made, and are easy to follow and understand
  • I have confirmed that all my code changes are indented properly using 2 spaces
  • I have filled out all fields above

@coveralls
Copy link

Pull Request Test Coverage Report for Build 816

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.507%

Totals Coverage Status
Change from base Build 810: 0.0%
Covered Lines: 2183
Relevant Lines: 2477

馃挍 - Coveralls

3 similar comments
@coveralls
Copy link

Pull Request Test Coverage Report for Build 816

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.507%

Totals Coverage Status
Change from base Build 810: 0.0%
Covered Lines: 2183
Relevant Lines: 2477

馃挍 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 816

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.507%

Totals Coverage Status
Change from base Build 810: 0.0%
Covered Lines: 2183
Relevant Lines: 2477

馃挍 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 816

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.507%

Totals Coverage Status
Change from base Build 810: 0.0%
Covered Lines: 2183
Relevant Lines: 2477

馃挍 - Coveralls

Copy link
Member

@fishcharlie fishcharlie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fishcharlie
Copy link
Member

Thanks for the PR @qisaw!! We will get this in for the next release.

@fishcharlie fishcharlie mentioned this pull request Jan 3, 2019
@fishcharlie fishcharlie merged commit ffb2605 into dynamoose:master Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants