Always use Array.isArray to check if array

[dobrynin]

Summary:

Change usage of array instanceOf Array and util.isArray(array) to Array.isArray(array).
My team found this to be an issue when trying to use the Model.batchPut.

Other information:

• array instanceof Array breaks when multiple Array globals exist: http://web.mit.edu/jwalden/www/isArray.html

• util.isArray is deprecated: https://nodejs.org/api/util.html#util_util_isarray_object

Type (select 1):

• Bug fix
• Feature implementation
• Documentation improvement
• Testing improvement

• Test added to report bug (GitHub issue #--- @---)
• Something not listed here

Is this a breaking change? (select 1):

• 🚨 YES 🚨
• No
• I'm not sure

Is this ready to be merged into Dynamoose? (select 1):

• Yes
• No

Are all the tests currently passing on this PR? (select 1):

• Yes
• No

Other:

• I have searched through the GitHub pull requests to ensure this PR has not already been submitted
• I have updated the Dynamoose documentation (if required) given the changes I made
• I have added/updated the Dynamoose test cases (if required) given the changes I made
• I have run npm test from the root of the project directory to ensure all tests continue to pass
• I agree that all changes made in this pull request may be distributed and are made available in accordance with the Dynamoose license
• All of my commits and commit messages are detailed, explain what changes were made, and are easy to follow and understand
• I have confirmed that all my code changes are indented properly using 2 spaces
• I have filled out all fields above

[coveralls]

Pull Request Test Coverage Report for Build 817

• 17 of 17 (100.0%) changed or added relevant lines in 4 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 85.507%

---

Totals
Change from base Build 810:	0.0%
Covered Lines:	2183
Relevant Lines:	2477

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 817

• 17 of 17 (100.0%) changed or added relevant lines in 4 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 85.507%

---

Totals
Change from base Build 810:	0.0%
Covered Lines:	2183
Relevant Lines:	2477

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 817

• 17 of 17 (100.0%) changed or added relevant lines in 4 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 85.507%

---

Totals
Change from base Build 810:	0.0%
Covered Lines:	2183
Relevant Lines:	2477

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 833

• 17 of 17 (100.0%) changed or added relevant lines in 4 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 85.447%

---

Totals
Change from base Build 832:	0.0%
Covered Lines:	2192
Relevant Lines:	2488

---

💛 - Coveralls

[fishcharlie]

@dobrynin

My team found this to be an issue when trying to use the Model.batchPut.

Mind adding a test case for this that fails without this PR and is successful with it? That would also be good because it would ensure your project doesn't break in the future.

[dobrynin]

Just pushed a test, please take a look @fishcharlie.

[fishcharlie]

@dobrynin Looks like there is a merge conflict. Wanna try to solve that?

[fishcharlie]

@dobrynin And just to confirm. That test you added, fails without your changes, correct?

[fishcharlie]

LGTM

[dobrynin]

All set. The test fails without these changes. The test is for the specific case that gave us trouble (batchPut)