Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLint #557

Merged
merged 8 commits into from Feb 4, 2019
Merged

ESLint #557

merged 8 commits into from Feb 4, 2019

Conversation

fishcharlie
Copy link
Member

Summary:

This PR adds support for ESLint to the project.

Type (select 1):

  • Bug fix
  • Feature implementation
  • Documentation improvement
  • Testing improvement
  • Test added to report bug (GitHub issue #--- @---)
  • Something not listed here

Is this a breaking change? (select 1):

  • 馃毃 YES 馃毃
  • No
  • I'm not sure

Is this ready to be merged into Dynamoose? (select 1):

  • Yes
  • No

Are all the tests currently passing on this PR? (select 1):

  • Yes
  • No

Other:

  • I have searched through the GitHub pull requests to ensure this PR has not already been submitted
  • I have updated the Dynamoose documentation (if required) given the changes I made
  • I have added/updated the Dynamoose test cases (if required) given the changes I made
  • I have run npm test from the root of the project directory to ensure all tests continue to pass
  • I agree that all changes made in this pull request may be distributed and are made available in accordance with the Dynamoose license
  • All of my commits and commit messages are detailed, explain what changes were made, and are easy to follow and understand
  • I have confirmed that all my code changes are indented properly using 2 spaces
  • I have filled out all fields above

@coveralls
Copy link

Pull Request Test Coverage Report for Build 874

  • 155 of 181 (85.64%) changed or added relevant lines in 9 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 85.707%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/Model.js 14 15 93.33%
lib/Scan.js 15 16 93.75%
lib/index.js 10 12 83.33%
lib/Plugin.js 41 44 93.18%
lib/Table.js 44 63 69.84%
Totals Coverage Status
Change from base Build 867: 0.1%
Covered Lines: 2216
Relevant Lines: 2510

馃挍 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented Feb 4, 2019

Pull Request Test Coverage Report for Build 874

  • 155 of 181 (85.64%) changed or added relevant lines in 9 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 85.707%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/Model.js 14 15 93.33%
lib/Scan.js 15 16 93.75%
lib/index.js 10 12 83.33%
lib/Plugin.js 41 44 93.18%
lib/Table.js 44 63 69.84%
Totals Coverage Status
Change from base Build 867: 0.1%
Covered Lines: 2216
Relevant Lines: 2510

馃挍 - Coveralls

@fishcharlie fishcharlie mentioned this pull request Feb 4, 2019
@fishcharlie fishcharlie merged commit e370ac5 into dynamoose:master Feb 4, 2019
@fishcharlie fishcharlie deleted the eslint branch February 4, 2019 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants