Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation Improvements #561

Merged
merged 1 commit into from Feb 4, 2019
Merged

Documentation Improvements #561

merged 1 commit into from Feb 4, 2019

Conversation

fishcharlie
Copy link
Member

Summary:

This PR makes a ton of documentation improvements

Type (select 1):

  • Bug fix
  • Feature implementation
  • Documentation improvement
  • Testing improvement
  • Test added to report bug (GitHub issue #--- @---)
  • Something not listed here

Is this a breaking change? (select 1):

  • 馃毃 YES 馃毃
  • No
  • I'm not sure

Is this ready to be merged into Dynamoose? (select 1):

  • Yes
  • No

Are all the tests currently passing on this PR? (select 1):

  • Yes
  • No

Other:

  • I have searched through the GitHub pull requests to ensure this PR has not already been submitted
  • I have updated the Dynamoose documentation (if required) given the changes I made
  • I have added/updated the Dynamoose test cases (if required) given the changes I made
  • I have ensured the following commands are successful from the root of the project directory
    • npm test
    • eslint .
  • I agree that all changes made in this pull request may be distributed and are made available in accordance with the Dynamoose license
  • All of my commits and commit messages are detailed, explain what changes were made, and are easy to follow and understand
  • I have filled out all fields above

@coveralls
Copy link

Pull Request Test Coverage Report for Build 882

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.582%

Totals Coverage Status
Change from base Build 881: 0.0%
Covered Lines: 2212
Relevant Lines: 2510

馃挍 - Coveralls

3 similar comments
@coveralls
Copy link

Pull Request Test Coverage Report for Build 882

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.582%

Totals Coverage Status
Change from base Build 881: 0.0%
Covered Lines: 2212
Relevant Lines: 2510

馃挍 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 882

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.582%

Totals Coverage Status
Change from base Build 881: 0.0%
Covered Lines: 2212
Relevant Lines: 2510

馃挍 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 882

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.582%

Totals Coverage Status
Change from base Build 881: 0.0%
Covered Lines: 2212
Relevant Lines: 2510

馃挍 - Coveralls

@fishcharlie fishcharlie mentioned this pull request Feb 4, 2019
@fishcharlie fishcharlie merged commit 005b362 into dynamoose:master Feb 4, 2019
@fishcharlie fishcharlie deleted the documentationupdates branch February 4, 2019 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants