Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(types): Update TypeScript and fix linting for exported types #701

Closed
wants to merge 1 commit into from

Conversation

kibertoad
Copy link

Is this ready to be merged into Dynamoose? (select 1):

  • Yes
  • No

Other:

  • I have searched through the GitHub pull requests to ensure this PR has not already been submitted
  • I agree that all changes made in this pull request may be distributed and are made available in accordance with the Dynamoose license
  • All of my commits and commit messages are detailed, explain what changes were made, and are easy to follow and understand
  • I have filled out all fields above

@coveralls
Copy link

coveralls commented Jan 12, 2020

Pull Request Test Coverage Report for Build 1142

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.485%

Totals Coverage Status
Change from base Build 1118: 0.0%
Covered Lines: 2106
Relevant Lines: 2406

💛 - Coveralls

@fishcharlie
Copy link
Member

@kibertoad Although I appreciate the PR, I kinda doubt this will get merged. With the version 2.0 rewrite (#677) there are lots of changes coming. The importance and bar for PRs to reach to get merged prior to 2.0 will continue to increase as more work is done on 2.0.

Just to make sure, this PR looks to be mainly styling changes. Is that correct, or am I missing something?

@kibertoad
Copy link
Author

Yup.

@kibertoad kibertoad closed this Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants