opentelemetrytracer: Dynatrace sampler: Use http_service in configuration. #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: thomas.ebner <thomas.ebner@dynatrace.com>
samohte
changed the title
samohte
changed the title
samohte
changed the title
joaopgrassi
reviewed
Mar 21, 2024
api/envoy/extensions/tracers/opentelemetry/samplers/v3/dynatrace_sampler.proto
Show resolved
Hide resolved
api/envoy/extensions/tracers/opentelemetry/samplers/v3/dynatrace_sampler.proto
Outdated
Show resolved
Hide resolved
source/extensions/tracers/opentelemetry/samplers/dynatrace/sampler_config_provider.cc
Show resolved
Hide resolved
test/extensions/tracers/opentelemetry/samplers/dynatrace/sampler_config_provider_test.cc
Show resolved
Hide resolved
…ce_sampler.proto Co-authored-by: Joao Grassi <5938087+joaopgrassi@users.noreply.github.com> Signed-off-by: Thomas Ebner <96168670+samohte@users.noreply.github.com>
Signed-off-by: thomas.ebner <thomas.ebner@dynatrace.com>
joaopgrassi
approved these changes
Mar 21, 2024
samohte
merged commit 815fc9c
into
feat/use-http-service-to-configure-dynatrace-sampler
3 checks passed
samohte
added a commit
that referenced
this pull request
Mar 28, 2024
envoyproxy#33034) * opentelemetrytracer: Dynatrace sampler: Use http_service in configuration. (#22) * change dynatrace sampler config to use http_service Signed-off-by: thomas.ebner <thomas.ebner@dynatrace.com> Signed-off-by: Thomas Ebner <96168670+samohte@users.noreply.github.com> Co-authored-by: Joao Grassi <5938087+joaopgrassi@users.noreply.github.com> * modify protobuf doc Signed-off-by: thomas.ebner <thomas.ebner@dynatrace.com> * remove empty line in proto file Signed-off-by: thomas.ebner <thomas.ebner@dynatrace.com> * added empty line in proto file Signed-off-by: thomas.ebner <thomas.ebner@dynatrace.com> * try to fix "Error in "code-block" directive" Signed-off-by: thomas.ebner <thomas.ebner@dynatrace.com> * fix "Error in "code-block" directive" Signed-off-by: thomas.ebner <thomas.ebner@dynatrace.com> * change proto documentation again Signed-off-by: thomas.ebner <thomas.ebner@dynatrace.com> * review feedback: keep unused values marked as deprecated. Add a new field. Signed-off-by: thomas.ebner <thomas.ebner@dynatrace.com> * Revert "review feedback: keep unused values marked as deprecated. Add a new" This reverts commit cec4b0f. Signed-off-by: thomas.ebner <thomas.ebner@dynatrace.com> --------- Signed-off-by: thomas.ebner <thomas.ebner@dynatrace.com> Signed-off-by: Thomas Ebner <96168670+samohte@users.noreply.github.com> Co-authored-by: Joao Grassi <5938087+joaopgrassi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: change Dynatrace sampler config to use http_service
Additional Description: In #32598 a custom Dynatrace sampler was added to Envoy. This sampler fetches its configuration via an HTTP call from a Dynatrace cluster. The endpoint and some additional information required to perform the HTTP call can be set in the Envoy config file.
While working on Istio changes to allow to set the endpoint, it turned out that it would be easier to use
http_serviceinstead ofhttp_uri.This also allows to configure additional HTTP headers which are added to the request.
Another benefit is that the configuration is now aligned to the HTTP exporter, see https://github.com/envoyproxy/envoy/blob/main/api/envoy/config/trace/v3/opentelemetry.proto#L42
Since the Dynatrace sampler is not yet released it should be ok to do config breaking change.
Risk Level: LOW
Testing: Unit, Integration, Manual
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A
[Optional Runtime guard:] N/A
[Optional Fixes #Issue] N/A
[Optional Fixes commit #PR or SHA] #32598, #32848
[Optional Deprecated:] N/A
[Optional API Considerations:] N/A