pg spans disconnected from parent (open-telemetry#225)

* chore: gitignore * chore: fixing context propagation for koa middleware layer
dynatrace-oss-contrib · Oct 28, 2020 · fa137d5 · fa137d5
1 parent b10fa3a
commit fa137d5
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 4 deletions.
diff --git a/plugins/node/opentelemetry-koa-instrumentation/src/koa.ts b/plugins/node/opentelemetry-koa-instrumentation/src/koa.ts
@@ -129,9 +129,12 @@ export class KoaInstrumentation extends BasePlugin<typeof koa> {
       const span = this._tracer.startSpan(metadata.name, {
         attributes: metadata.attributes,
       });
-      const result = await middlewareLayer(context, next);
-      span.end();
-      return result;
+
+      return this._tracer.withSpan(span, async () => {
+        const result = await middlewareLayer(context, next);
+        span.end();
+        return result;
+      });
     };
   }
 }

diff --git a/plugins/node/opentelemetry-koa-instrumentation/test/koa.test.ts b/plugins/node/opentelemetry-koa-instrumentation/test/koa.test.ts
@@ -93,6 +93,12 @@ describe('Koa Instrumentation - Core Tests', () => {
     await next();
   };
 
+  const spanCreateMiddleware: koa.Middleware = async (ctx, next) => {
+    const span = tracer.startSpan('foo');
+    span.end();
+    await next();
+  };
+
   const asyncMiddleware: koa.Middleware = async (ctx, next) => {
     const start = Date.now();
     await next();
@@ -106,11 +112,12 @@ describe('Koa Instrumentation - Core Tests', () => {
       app.use((ctx, next) => tracer.withSpan(rootSpan, next));
       app.use(customMiddleware);
       app.use(simpleResponse);
+      app.use(spanCreateMiddleware);
 
       await tracer.withSpan(rootSpan, async () => {
         await httpRequest.get(`http://localhost:${port}`);
         rootSpan.end();
-        assert.deepStrictEqual(memoryExporter.getFinishedSpans().length, 5);
+        assert.deepStrictEqual(memoryExporter.getFinishedSpans().length, 8);
 
         assert.notStrictEqual(
           memoryExporter
@@ -119,6 +126,18 @@ describe('Koa Instrumentation - Core Tests', () => {
           undefined
         );
 
+        const fooParentSpan = memoryExporter
+          .getFinishedSpans()
+          .find(span => span.name.includes('spanCreateMiddleware'));
+        assert.notStrictEqual(fooParentSpan, undefined);
+
+        const fooSpan = memoryExporter.getFinishedSpans().find(span => 'foo');
+        assert.notStrictEqual(fooSpan, undefined);
+        assert.strictEqual(
+          fooSpan!.parentSpanId,
+          fooParentSpan!.spanContext.spanId
+        );
+
         const simpleResponseSpan = memoryExporter
           .getFinishedSpans()
           .find(span => span.name.includes('simpleResponse'));