forked from cloudevents/spec
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify usage of Distributed Tracing Extension by OpenTelemetry #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still not merged, but at least it's there.
pirgeo
approved these changes
Nov 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good to me. I guess this will only be merged after the spec PR, right? the link is currently dead because the cloudevents.md
is not yet merged.
arminru
approved these changes
Nov 18, 2021
Changed also the introduction a bit to "link" this extension with OTel more clearly.
joaopgrassi
force-pushed
the
otel_semconv_dte_review
branch
from
November 18, 2021 10:20
f867b18
to
9066490
Compare
joaopgrassi
force-pushed
the
otel_semconv_dte_review
branch
from
November 18, 2021 14:19
951ab43
to
d2ec4bb
Compare
pirgeo
approved these changes
Nov 18, 2021
arminru
approved these changes
Nov 18, 2021
joaopgrassi
changed the title
Clarify usage of Distributed Tracing Extension
Clarify usage of Distributed Tracing Extension by OpenTelemetry
Nov 19, 2021
joaopgrassi
added a commit
that referenced
this pull request
Nov 19, 2021
Signed-off-by: Joao Grassi <joao.grassi@dynatrace.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the last messaging workgroup meeting, it was pointed out that now that we are close to merge the CloudEvents Semantic Conventions PR, we should make it clear in the CloudEvents spec that the Distributed Tracing Extension is used by OTel.
The reason for this "linking" between specs is that the extension caused confusion in the past and was even asked to be removed: cloudevents#751. Basically the idea is that OpenTelemetry "claims" this extension and by providing the semantic conventions, its usage becomes more clear.
Here is the recording of the meeting where this subject came up: https://youtu.be/gjz3Fz_hz_8?t=937
So, in this PR I intended to: