Skip to content

Commit

Permalink
ci(bazel): Fixes an issue where bazel could not create runfiles on wi…
Browse files Browse the repository at this point in the history
…ndows.

This issue is due to som legacy runfiles linking where a manifest file was expected where it was not on windows.
  • Loading branch information
Lukas Holzer committed Sep 8, 2020
1 parent 61ce9ab commit 0917825
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
8 changes: 7 additions & 1 deletion .bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,13 @@ build:debug --compilation_mode=dbg
# Turn off legacy external runfiles
# This prevents accidentally depending on this feature, which Bazel will remove.
build --nolegacy_external_runfiles
run --nolegacy_external_runfiles
test --nolegacy_external_runfiles

# Do not build runfile forests by default. If an execution strategy relies on runfile
# forests, the forest is created on-demand. See: https://github.com/bazelbuild/bazel/issues/6627
# and https://github.com/bazelbuild/bazel/commit/03246077f948f2790a83520e7dccc2625650e6df
build --nobuild_runfile_links


# Turn on --incompatible_strict_action_env which was on by default
Expand Down Expand Up @@ -116,7 +123,6 @@ test --spawn_strategy=local

build --experimental_inprocess_symlink_creation


# ------------------------------------------------------------------------------------------------
# Possible overrides
# ------------------------------------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion WORKSPACE
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ npm_install(
],
package_json = "//:package.json",
package_lock_json = "//:package-lock.json",
quiet = False,
quiet = True,
symlink_node_modules = True,
)

Expand Down

0 comments on commit 0917825

Please sign in to comment.