Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stylelint to the circlecli #1160

Merged
merged 1 commit into from Jul 8, 2020
Merged

Add stylelint to the circlecli #1160

merged 1 commit into from Jul 8, 2020

Conversation

lukasholzer
Copy link
Contributor

Pull Request

Hi, thank you for contributing to Barista with this pull request (PR).

To ensure a fast process and merging of your PR please make sure it fulfills the
coding standards and contribution guidelines.

  • A feature proposal has been provided, discussed and approved first.
  • There is a meaningful description of the issue in GitHub (Screenshots are
    often helpful).
  • If the PR introduces breaking-changes or deprecations it matches the following
    guidelines.
    • The commit message follows our commit guidelines.
    • Tests for the changes have been added (for bug fixes / features).
    • Docs have been added / updated (for bug fixes / features).

Please choose the type appropriate for the changes below:

Type of PR

Checklist

  • I have read the CONTRIBUTING doc and I follow the PR guidelines
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@lukasholzer lukasholzer marked this pull request as draft June 15, 2020 14:59
@github-actions
Copy link

Deploy preview for barista ready!

Built with commit 32a4e78

✅ Preview: https://barista-55l4e0tta.vercel.app

This pull request is being automatically deployed with now-deployment

@lukasholzer lukasholzer force-pushed the ci/run-styleint-bazel-on-ci branch 3 times, most recently from e913d4b to db989c6 Compare June 15, 2020 15:22
@github-actions
Copy link

Deploy preview for barista ready!

Built with commit 146e7c7

✅ Preview: https://barista-74rpsx99e.vercel.app

This pull request is being automatically deployed with now-deployment

@github-actions
Copy link

Deploy preview for barista ready!

Built with commit e913d4b

✅ Preview: https://barista-a2pn84ebg.vercel.app

This pull request is being automatically deployed with now-deployment

@github-actions
Copy link

Deploy preview for barista ready!

Built with commit db989c6

✅ Preview: https://barista-24wh73v1u.vercel.app

This pull request is being automatically deployed with now-deployment

@github-actions
Copy link

Deploy preview for barista ready!

Built with commit cfd7120

✅ Preview: https://barista-j8i1su60s.vercel.app

This pull request is being automatically deployed with now-deployment

@github-actions
Copy link

Deploy preview for barista ready!

Built with commit 467e605

✅ Preview: https://barista-mdp0wdm4y.vercel.app

This pull request is being automatically deployed with now-deployment

@github-actions
Copy link

Deploy preview for barista ready!

Built with commit 2f572e4

✅ Preview: https://barista-j645cbwr8.vercel.app

This pull request is being automatically deployed with now-deployment

@github-actions
Copy link

Deploy preview for barista ready!

Built with commit 48ecc68

✅ Preview: https://barista-q0lgzc0f8.vercel.app

This pull request is being automatically deployed with now-deployment

@github-actions
Copy link

Deploy preview for barista ready!

Built with commit 27a1031

✅ Preview: https://barista-a04e7ru13.vercel.app

This pull request is being automatically deployed with now-deployment

@lukasholzer lukasholzer force-pushed the ci/run-styleint-bazel-on-ci branch 2 times, most recently from 5f54c25 to e40b7f6 Compare June 16, 2020 11:15
@github-actions
Copy link

Deploy preview for barista ready!

Built with commit e40b7f6

✅ Preview: https://barista-oxuwzxioi.vercel.app

This pull request is being automatically deployed with now-deployment

@github-actions
Copy link

Deploy preview for barista ready!

Built with commit 5f54c25

✅ Preview: https://barista-nac665nxg.vercel.app

This pull request is being automatically deployed with now-deployment

@github-actions
Copy link

Deploy preview for barista ready!

Built with commit 0712a43

✅ Preview: https://barista-94g2tnx22.vercel.app

This pull request is being automatically deployed with now-deployment

@github-actions
Copy link

Deploy preview for barista ready!

Built with commit 90be0d0

✅ Preview: https://barista-43d8rtjc1.vercel.app

This pull request is being automatically deployed with now-deployment

@lukasholzer
Copy link
Contributor Author

If the stacked-bar-chart PR gets merged rebase this one and refactor the stylelint target.

#988

@furtnerl furtnerl force-pushed the ci/run-styleint-bazel-on-ci branch from 8f4b433 to d5e26f6 Compare June 29, 2020 06:13
@tomheller tomheller added the bazel All issues realted to bazel build system label Jul 3, 2020
@furtnerl furtnerl force-pushed the ci/run-styleint-bazel-on-ci branch from f14253a to e0ff94a Compare July 6, 2020 10:24
@github-actions
Copy link

github-actions bot commented Jul 7, 2020

Deploy preview for barista ready!

Built with commit 921841a

✅ Preview: https://barista-nlkf2177n.vercel.app

This pull request is being automatically deployed with now-deployment

@furtnerl furtnerl force-pushed the ci/run-styleint-bazel-on-ci branch from 1008fc3 to 7529bf8 Compare July 7, 2020 08:07
@github-actions
Copy link

github-actions bot commented Jul 7, 2020

Deploy preview for barista ready!

Built with commit 1008fc3

✅ Preview: https://barista-cqjfx86ip.vercel.app

This pull request is being automatically deployed with now-deployment

@github-actions
Copy link

github-actions bot commented Jul 7, 2020

Deploy preview for barista ready!

Built with commit 7529bf8

✅ Preview: https://barista-r7srsup14.vercel.app

This pull request is being automatically deployed with now-deployment

@furtnerl furtnerl force-pushed the ci/run-styleint-bazel-on-ci branch from 7529bf8 to 608d2ba Compare July 7, 2020 08:55
@github-actions
Copy link

github-actions bot commented Jul 7, 2020

Deploy preview for barista ready!

Built with commit 608d2ba

✅ Preview: https://barista-ea1bz5g00.vercel.app

This pull request is being automatically deployed with now-deployment

@github-actions
Copy link

github-actions bot commented Jul 7, 2020

Deploy preview for barista ready!

Built with commit 1fea56f

✅ Preview: https://barista-cd2e6eoah.vercel.app

This pull request is being automatically deployed with now-deployment

@furtnerl furtnerl force-pushed the ci/run-styleint-bazel-on-ci branch from 1fea56f to 2432e1b Compare July 7, 2020 13:01
@github-actions
Copy link

github-actions bot commented Jul 7, 2020

Deploy preview for barista ready!

Built with commit 2432e1b

✅ Preview: https://barista-cy6657lkw.vercel.app

This pull request is being automatically deployed with now-deployment

@furtnerl furtnerl marked this pull request as ready for review July 7, 2020 13:19
@furtnerl furtnerl requested a review from rowa-audil as a code owner July 7, 2020 13:19
@furtnerl furtnerl force-pushed the ci/run-styleint-bazel-on-ci branch from 2432e1b to 1d73e72 Compare July 8, 2020 06:02
lukasholzer
lukasholzer commented Jul 8, 2020
View reviewed changes
.circleci/config.yml Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
lukasholzer
lukasholzer commented Jul 8, 2020
View reviewed changes
WORKSPACE Show resolved Hide resolved
libs/shared/design-system/ui/BUILD.bazel Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Jul 8, 2020

Deploy preview for barista ready!

Built with commit 1d73e72

✅ Preview: https://barista-c7t2be0i3.vercel.app

This pull request is being automatically deployed with now-deployment

@furtnerl
ci(bazel): Run Stylelint on circleci
55e20a1 
Update our Circleci workflow and add one for the bazel targets.
Run all stylelint targets and remove them from the angular json.
@furtnerl furtnerl force-pushed the ci/run-styleint-bazel-on-ci branch from 1d73e72 to 55e20a1 Compare July 8, 2020 06:15
@github-actions
Copy link

github-actions bot commented Jul 8, 2020

Deploy preview for barista ready!

Built with commit 55e20a1

✅ Preview: https://barista-krzc96lj9.vercel.app

This pull request is being automatically deployed with now-deployment

furtnerl
furtnerl approved these changes Jul 8, 2020
View reviewed changes
Copy link
Contributor

@furtnerl furtnerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am approving on behalf of Lukas Holzer, as he openend the PR and I finished it

ffriedl89
ffriedl89 approved these changes Jul 8, 2020
View reviewed changes
Copy link
Collaborator

@ffriedl89 ffriedl89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh the magic ✨ LGTM

.dockerignore
@@ -3,7 +3,7 @@
#--------------------------
**

#--------------------------
#--------------------------a
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#--------------------------a
#--------------------------

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:D

@lukasholzer lukasholzer added the pr: merge-ready This PR is ready to be merged label Jul 8, 2020
@github-actions github-actions bot added target: minor This PR is targeted for the next minor release target: patch This PR is targeted for the next patch release labels Jul 8, 2020
@lukasholzer lukasholzer merged commit 3b5fc81 into master Jul 8, 2020
@lukasholzer lukasholzer deleted the ci/run-styleint-bazel-on-ci branch July 8, 2020 07:55
@github-actions
Copy link

github-actions bot commented Jul 8, 2020

The auto cherry picker succeeded.Cherry picked to minor branch 7.x. New head is now 67345b4
Cherry picked to patch branch 7.2.x. New head is now 9da7055

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ffriedl89 ffriedl89 ffriedl89 approved these changes

@furtnerl furtnerl furtnerl approved these changes

@thomaspink thomaspink Awaiting requested review from thomaspink

@tomheller tomheller Awaiting requested review from tomheller tomheller is a code owner

@rowa-audil rowa-audil Awaiting requested review from rowa-audil

Assignees
No one assigned
Labels
bazel All issues realted to bazel build system pr: merge-ready This PR is ready to be merged target: minor This PR is targeted for the next minor release target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lukasholzer @ffriedl89 @furtnerl @tomheller