barista: Modifying isChild condition for avoiding opening wrong nodes #1351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @PedroMosquera! Thank you for this contribution the code looks good. Would it make sense to add a test case for this, so we can make sure that this behaviour will not break in the future? |
|
Sure thing @tomheller, it totally makes sense. I'm working on those now 😄 |
lukasholzer
previously approved these changes
Jul 23, 2020
|
@PedroMosquera please rebase with the latest master as there is a fix why build, stylelint and unit_test is failing |
PedroMosquera
force-pushed
the
barista/sunburst-chart-opening-additional-children
branch
2 times, most recently
from
60973f1
to
f7341fc
Compare
|
@lukasholzer I've just rebased master and those tasks are still failing. Not sure if I have to do something more |
tomheller
force-pushed
the
barista/sunburst-chart-opening-additional-children
branch
from
f7341fc
to
3308198
Compare
|
Hi @PedroMosquera! |
tomheller
approved these changes
Jul 27, 2020
tomheller
added
pr: needs-cherry-pick
|
Cherry pick done. |
PedroMosquera
deleted the
barista/sunburst-chart-opening-additional-children
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Fixes #1245
The current sunburst uses IDs as a representation for each node. You can easy see the parent of every child by the base of their ID.
e.g.: node with ID
1.3.1is the child of the node with1.3.The current issue is that the application returns
truewhen you ask if1.12.1is the child of1.1Type of PR
Bugfix (non-breaking change which fixes an issue)
Checklist