Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

barista: Use images instead of inline svgs for icons. #761

Merged
merged 1 commit into from Mar 25, 2020
Merged

barista: Use images instead of inline svgs for icons. #761

merged 1 commit into from Mar 25, 2020

Conversation

lara-aigmueller
Copy link
Contributor

@lara-aigmueller lara-aigmueller commented Mar 19, 2020 •
edited

Pull Request

closes #750

Updated the GitHub link to dynatrace-oss

Type of PR

Barista improvement

@lara-aigmueller lara-aigmueller self-assigned this Mar 19, 2020
@github-actions
Copy link

github-actions bot commented Mar 19, 2020 •
edited

Deploy preview for website ready!

Built with commit 703f5fd

https://barista-design-system-l99sy29nl.now.sh

tomheller
tomheller previously approved these changes Mar 19, 2020
View reviewed changes
lukasholzer
lukasholzer previously approved these changes Mar 19, 2020
View reviewed changes
@lukasholzer
Copy link
Contributor

lukasholzer commented Mar 19, 2020 •
edited

thx great but id does not close the issue to 100% it is a part of it there are so many more svgs like the miniature icons on the tiles etc.

Thx! Great PR :)

But we should be aware that it does not close the related issue. It is only a part of this issue with the svgs in the footer. There are some more occurrences for example in the tiles.

The experimental and work in progress icons for examples.

Please check in a followup PR or in this one for further usages of svg in the template.

@lara-aigmueller
Copy link
Contributor Author

thx great but id does not close the issue to 100% it is a part of it there are so many more svgs like the miniature icons on the tiles etc.

Alright, I added a wip-label and will search for all the missing svgs and add it to this PR.

@lara-aigmueller lara-aigmueller changed the title barista: Use img instead of inline svgs for social icons. barista: Use images instead of inline svgs for icons. Mar 23, 2020
@lara-aigmueller
Copy link
Contributor Author

I did not move the ba-tile-status-icon-triangle to an svg-asset, because as inlined svg it's much easier to theme it according to the page-theme (and it's used on all overview-pages).

@sonarcloud
Copy link

sonarcloud bot commented Mar 23, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

lukasholzer
lukasholzer approved these changes Mar 23, 2020
View reviewed changes
Copy link
Contributor

@lukasholzer lukasholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🐝

@tomheller tomheller added the pr: merge-ready This PR is ready to be merged label Mar 25, 2020
@github-actions github-actions bot added target: minor This PR is targeted for the next minor release target: patch This PR is targeted for the next patch release labels Mar 25, 2020
@ffriedl89 ffriedl89 merged commit 6e069ee into master Mar 25, 2020
@ffriedl89 ffriedl89 deleted the barista/svg-assets branch March 25, 2020 10:05
@github-actions
Copy link

@dynatrace-oss/barista, the auto cherry picker failed. Please have a look at the failure and cherry pick by hand.

@ffriedl89
Copy link
Collaborator

took care of the cherry pick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomheller tomheller tomheller approved these changes

@lukasholzer lukasholzer lukasholzer approved these changes

@NinaKammerlander NinaKammerlander NinaKammerlander approved these changes

@thomaspink thomaspink Awaiting requested review from thomaspink

@rowa-audil rowa-audil Awaiting requested review from rowa-audil

Assignees

@lara-aigmueller lara-aigmueller

Labels
design-system pr: merge-ready This PR is ready to be merged target: minor This PR is targeted for the next minor release target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Barista: Extract inline SVGs from the template to assets
5 participants
@lara-aigmueller @lukasholzer @ffriedl89 @tomheller @NinaKammerlander