Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PCLOUDS-1428: Remove Function deployment type #431

Merged
merged 9 commits into from
Sep 14, 2023
Merged

PCLOUDS-1428: Remove Function deployment type #431

merged 9 commits into from
Sep 14, 2023

Conversation

joaquinfilipic-dynatrace
Copy link
Contributor

@joaquinfilipic-dynatrace joaquinfilipic-dynatrace commented Aug 30, 2023 •
edited

Summary:

  • No behavior from GKE deployment was added/removed (hopefully 😛).
  • Removed 'gcp-install-release' pipeline stage, which was deploying a Cloud Function instance in our dev env with the latest release, and deleted Cloud Function deployment script files.
  • Cleaned code and deleted files related to the Cloud Function deployment type's flow.

Check:

  • Before merging this, make sure to sync with customers (setup.sh has a var at the beginning that has to point to 'release-1.1.8' at most).

@szymon-nagel-dt
Copy link
Collaborator

What about this one?
image

@dtwwolinski
Copy link
Contributor

Readme should be updated.

@dtwwolinski
Copy link
Contributor

is the gcp_iam_roles/dynatrace-gcp-monitor-cloud-function-deployment-role.yaml file needed?

@dtwwolinski
Copy link
Contributor

img\architecture-k8s.svg
img\architecture-multi-project.svg
img\logs-architecture.svg
Still contain "dynatrace-gcp-function" can you rename the entries?

dtwwolinski
dtwwolinski suggested changes Sep 13, 2023
View reviewed changes
src/run_docker.py Show resolved Hide resolved
src/run_docker.py Outdated Show resolved Hide resolved
tests/unit/test_run_docker.py Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Sep 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@joaquinfilipic-dynatrace joaquinfilipic-dynatrace merged commit 8148191 into master Sep 14, 2023
5 checks passed
@joaquinfilipic-dynatrace joaquinfilipic-dynatrace deleted the PCLOUDS-1428-Remove_function_deployment branch September 14, 2023 13:00
@joaquinfilipic-dynatrace joaquinfilipic-dynatrace restored the PCLOUDS-1428-Remove_function_deployment branch November 2, 2023 15:16
@joaquinfilipic-dynatrace joaquinfilipic-dynatrace deleted the PCLOUDS-1428-Remove_function_deployment branch November 2, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtwwolinski dtwwolinski dtwwolinski approved these changes

@NematulloKozimov NematulloKozimov NematulloKozimov approved these changes

@mmajcher mmajcher Awaiting requested review from mmajcher

@nikita-paskal-dynatrace nikita-paskal-dynatrace Awaiting requested review from nikita-paskal-dynatrace

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@joaquinfilipic-dynatrace @szymon-nagel-dt @dtwwolinski @NematulloKozimov