NOISSUE: Small updates in e2e tests and dependencies #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
joaquinfilipic-dynatrace
commented
Dec 7, 2023
•
joaquinfilipic-dynatrace
commented
- Dependencies updates
- Adding sleep between creation of resources and E2E tests running (some resources need time to work properly)
- Running E2E tests only on master and on PRs (skipping pushes to dev branches)
|
Kudos, SonarCloud Quality Gate passed!
|
| @@ -17,9 +17,9 @@ source ./tests/e2e/lib-tests.sh | |||
|
|
|||
| helm -n dynatrace ls --all --short | grep dynatrace-gcp-monitor | xargs -L1 helm -n dynatrace uninstall --timeout 10m | |||
|
|
|||
| gcloud logging sinks delete "${LOG_ROUTER}" | |||
There was a problem hiding this comment.
This is only to avoid some errors being logged when the sink was not finding the topic, between deletions.
| @@ -20,7 +20,7 @@ TEST_JQ=ext_tools/jq_linux_x64 | |||
| create_sample_app() { | |||
| echo "Deploying sample app" | |||
| gcloud functions deploy "${CLOUD_FUNCTION_NAME}" \ | |||
| --runtime python37 \ | |||
| --runtime python38 \ | |||
There was a problem hiding this comment.
Because 3.7 is deprecated
joaquinfilipic-dynatrace
requested review from
dtwwolinski,
NematulloKozimov and
olegkozel
olegkozel
approved these changes
Dec 7, 2023
dtwwolinski
approved these changes
Dec 8, 2023
joaquinfilipic-dynatrace
deleted the
NOISSUE-Custom_extensions_info_and_small_updates
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.