PCLOUDS-3748: Adjusted align and reduce aggregations #485
Conversation
|
| elif metric_kind.lower().startswith('gauge'): | ||
| reducer = 'REDUCE_COUNT_TRUE' if value_type.lower() == 'bool' else 'REDUCE_MEAN' | ||
|
|
||
| return reducer |
There was a problem hiding this comment.
General comment about these 2 functions: would you consider creating dictionaries with the aligners and reducers? Then we will separate data from the functions, also you could assign keys like default_aligner, which often are better than comments. "Code never lies, comments sometimes do." 😄
Btw, if you do decide about using the dict, there is this MappingProxyType which is immutable, which may be desired for such a use case.
There was a problem hiding this comment.
I agree with separating data from the functions, but I don't want to maintain keys that I won't use. As we have it now, I don't care for most of the possible values for the types, for instance. And I won't go half way, this is too simple for me to deserve it.
There was a problem hiding this comment.
Sure, valid points 😄
| @@ -350,7 +373,7 @@ def create_entity_id(service_name: str, service_dimensions: List[Dimension], tim | |||
| return entity_id | |||
|
|
|||
|
|
|||
| def convert_point_to_ingest_line( | |||
| def _convert_point_to_ingest_line( | |||
There was a problem hiding this comment.
Nice of you to include some code cleaning! 😄
There was a problem hiding this comment.
We can do minor things like this in every PR, when we spot them
joaquinfilipic-dynatrace
deleted the
PCLOUDS-3748-Metrics_aligner_and_reducer_fix
branch
No description provided.