Bugfix - allow for using VPC networks with custom subnet creation #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emjot13-dynatrace
requested review from
NematulloKozimov,
joaquinfilipic-dynatrace,
nikita-paskal-dynatrace and
szymon-nagel-dt
szymon-nagel-dt
approved these changes
Apr 18, 2024
joaquinfilipic-dynatrace
approved these changes
Apr 18, 2024
True, docs need the new params |
…of using the default one more context: when creating a VPC network the default option is creating a custom subnet in this network, then when this network is passed in the values.yaml the creation of autopilot would fail because no subnet was passed, now it's possible to use both VPC networks with automatic subnets and custom ones also split a few long lines into more lines
emjot13-dynatrace
force-pushed
the
bugfix/PCLOUDS-4094-create-autopilot-cluster-failing-on-custom-subnet
branch
from
fc8b158
to
ea60e73
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option to use the VPCs created with custom subnets for cluster creation.
More context: when creating a VPC network the default option is creating custom subnets in this network,
then when this network is passed in the
values.yaml, creating an autopilot cluster would fail because no subnet was specified.Now it's possible to use VPC networks with both automatic and custom subnets.
Additionally, added some small cleaning, mainly breaking too long lines and fixing small inconsistencies.