fix(file.util): avoid inotify problems in containers by using polling over FileWatcher #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… over FileWatcher
pichlermarc
force-pushed
the
fix/default-to-poll-based
branch
from
a1affd3
to
47843bc
Compare
joaopgrassi
approved these changes
Apr 25, 2024
…polling over FileWatcher
… using polling over FileWatcher
arminru
approved these changes
Apr 25, 2024
lib/src/main/java/com/dynatrace/file/util/FilePollerFactory.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Armin Ruech <7052238+arminru@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using bind-mounts in containers the FileWatcher may not pick up changes to the file, causing the watch-service-based implementation to miss updates to the file. This becomes problematic on token rotations.
This PR switches the implementation to use the
PollBasedFilePoller(60 second interval) instead.Tests:
Additional Resources