Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split large spans into multiple export messages #36

Merged
merged 9 commits into from
Oct 10, 2023
Merged

Split large spans into multiple export messages #36

merged 9 commits into from
Oct 10, 2023

Conversation

Kwintenvdb
Copy link
Contributor

No description provided.

mariojonke
mariojonke reviewed Sep 21, 2023
View reviewed changes
core/configuration/dt_config_provider.go Outdated Show resolved Hide resolved
core/trace/dt_span_exporter.go Outdated Show resolved Hide resolved
core/trace/dt_span_exporter.go Outdated Show resolved Hide resolved
Oberon00
Oberon00 requested changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@Oberon00 Oberon00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some unit tests. I guess the case where we don't split the message should already be covered, but try to exercise the major code paths at least (ADD, BUFFER, DROP)

Oberon00
Oberon00 previously approved these changes Oct 6, 2023
View reviewed changes
mariojonke
mariojonke previously approved these changes Oct 10, 2023
View reviewed changes
@Kwintenvdb Kwintenvdb dismissed stale reviews from mariojonke and Oberon00 via 92e64b4 October 10, 2023 08:26
@Kwintenvdb Kwintenvdb merged commit fe1d3a6 into main Oct 10, 2023
4 checks passed
@Kwintenvdb Kwintenvdb deleted the kvb/serialization-splitting branch October 10, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariojonke mariojonke mariojonke approved these changes

@Oberon00 Oberon00 Awaiting requested review from Oberon00

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Kwintenvdb @Oberon00 @mariojonke