Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve reading config file #38

Merged
merged 3 commits into from
Dec 21, 2023
Merged

Improve reading config file #38

merged 3 commits into from
Dec 21, 2023

Conversation

Kwintenvdb
Copy link
Contributor

This PR introduces 2 changes:

  1. Allows specifying the config file path via environment variable.
  2. When running in Google Cloud Functions, uses the default path ./serverless_function_source_code/dtconfig.json rather than ./dtconfig.json.

As already discussed with @Bataran, this makes PR #37 redundant, and will be closed.

Bataran
Bataran previously approved these changes Dec 20, 2023
View reviewed changes
Ma-Ba
Ma-Ba previously approved these changes Dec 20, 2023
View reviewed changes
@Bataran Bataran mentioned this pull request Dec 20, 2023
Closed
@Kwintenvdb Kwintenvdb dismissed stale reviews from Ma-Ba and Bataran via 76cc653 December 20, 2023 10:45
@Kwintenvdb Kwintenvdb merged commit bf40949 into main Dec 21, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oberon00 Oberon00 Oberon00 left review comments

@Bataran Bataran Bataran left review comments

@Ma-Ba Ma-Ba Ma-Ba approved these changes

@mariojonke mariojonke Awaiting requested review from mariojonke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Kwintenvdb @Oberon00 @Bataran @Ma-Ba