Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3024 Added Dynaflow Modelica model IEEE57 #3025

Merged
merged 1 commit into from
Jul 2, 2024
Merged

#3024 Added Dynaflow Modelica model IEEE57 #3025

merged 1 commit into from
Jul 2, 2024

Conversation

joyelfeghali
Copy link
Contributor

Checklist before requesting a review

use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes

  • unit tests and non-regression tests were added (new model, new feature and bug fix)
  • main documentation was updated (update of input/output file, 3rd party, model, repository organization, solver)
  • example documentations were updated (new example in examples folder)
  • the corresponding milestone was added in the ticket and in this PR
  • if this PR modifies the parameters or inputs/outputs of a model/solver: the corresponding xsl was added in util/xsl and platform DB were updated
  • if this PR modifies a dictionary: the corresponding french dictionary was updated

@joyelfeghali
Copy link
Contributor Author

1 . Three test cases of IEEE 57-bus model were added :

  • IEEE57 with no Events
  • IEEE57 with line disconnection
  • IEEE57 with HVDC and PhaseShifter models and line disconnection
  1. Examples package were reorganized :
  • IEEE57
  • IEEE14
  • Illustrative Examples
  1. alphaTfo parameter/variable replaced thetaTfo

@joyelfeghali
Copy link
Contributor Author

@rosiereflo I am not sure if we need to add updateXML here ? since the paths I modified are only for Modelica examples so technically they are not unit dynamic models, it is the whole test case.
I added the file, I can remove it if unecessary

@rosiereflo
Copy link
Contributor

@rosiereflo I am not sure if we need to add updateXML here ? since the paths I modified are only for Modelica examples so technically they are not unit dynamic models, it is the whole test case. I added the file, I can remove it if unecessary

Hi this is always useful to add them so thanks!

@joyelfeghali joyelfeghali force-pushed the 3024_IEEE57 branch 2 times, most recently from f2d8a23 to 5704952 Compare June 26, 2024 07:41
@joyelfeghali joyelfeghali force-pushed the 3024_IEEE57 branch 3 times, most recently from 4b94b79 to 49eeec7 Compare June 27, 2024 14:13
Copy link
Contributor

@gaouizer gaouizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems OK to me

…rganized Examples folder and initialisation model for transformers

Signed-off-by: Joy El Feghali <joy.elfeghali@rte-france.com>
@gaouizer gaouizer merged commit 5dc335e into master Jul 2, 2024
5 checks passed
@gaouizer gaouizer deleted the 3024_IEEE57 branch July 2, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add IEEE benchmarks to Modelica examples
3 participants