Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3242 if structures rewritten in order to avoid IDA failure, useless … #3258

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

ErwanGuichard49
Copy link
Collaborator

…parameters removed from .par

Veuillez saisir le message de validation pour vos modifications. Les lignes

Checklist before requesting a review

use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes

  • unit tests and non-regression tests were added (new model, new feature and bug fix)
  • main documentation was updated (update of input/output file, 3rd party, model, repository organization, solver)
  • example documentations were updated (new example in examples folder)
  • the corresponding milestone was added in the ticket and in this PR
  • if this PR modifies the parameters or inputs/outputs of a model/solver: the corresponding xsl was added in util/xsl and platform DB were updated
  • if this PR modifies a dictionary: the corresponding french dictionary was updated

@ErwanGuichard49 ErwanGuichard49 added Bug Something isn't working Models library labels Jun 3, 2024
@ErwanGuichard49 ErwanGuichard49 added this to the v1.7.0 milestone Jun 3, 2024
@ErwanGuichard49 ErwanGuichard49 force-pushed the 3242_if_structures_rewritten branch 3 times, most recently from f5312e4 to 208038f Compare June 10, 2024 14:31
@ErwanGuichard49 ErwanGuichard49 force-pushed the 3242_if_structures_rewritten branch 2 times, most recently from a77d33c to 473983f Compare June 18, 2024 08:54
@ErwanGuichard49 ErwanGuichard49 force-pushed the 3242_if_structures_rewritten branch 4 times, most recently from fd33d79 to b218d39 Compare July 3, 2024 09:48
@ErwanGuichard49 ErwanGuichard49 force-pushed the 3242_if_structures_rewritten branch 3 times, most recently from 91bb90d to 67fb0f4 Compare July 5, 2024 08:47
@joyelfeghali joyelfeghali linked an issue Jul 5, 2024 that may be closed by this pull request
joyelfeghali
joyelfeghali previously approved these changes Jul 5, 2024
@ErwanGuichard49
Copy link
Collaborator Author

I am checking the nrt, please do not merge before they have passed.

…parameters removed from .par, reference .csv updated

Signed-off-by: Erwan Guichard <erwan.guichard_externe@rte-france.com>
@ErwanGuichard49
Copy link
Collaborator Author

The nrt references have been updated. The branch can thus be merged.

@joyelfeghali joyelfeghali merged commit 8cbff5b into master Jul 5, 2024
5 checks passed
@joyelfeghali joyelfeghali deleted the 3242_if_structures_rewritten branch July 5, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Models library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IDA failure if parameter has no default value
2 participants