-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#3253 Add the 2015 version of the IEC WPP models #3274
base: master
Are you sure you want to change the base?
Conversation
Thanks for adding the python script! |
fff987c
to
505e3b6
Compare
...o/sources/Models/Modelica/Dynawo/Electrical/Controls/IEC/BaseControls/WPP/WPPPControl2015.mo
Outdated
Show resolved
Hide resolved
...o/sources/Models/Modelica/Dynawo/Electrical/Controls/IEC/BaseControls/WPP/WPPPControl2015.mo
Outdated
Show resolved
Hide resolved
...o/sources/Models/Modelica/Dynawo/Electrical/Controls/IEC/BaseControls/WPP/WPPPControl2015.mo
Outdated
Show resolved
Hide resolved
...o/sources/Models/Modelica/Dynawo/Electrical/Controls/IEC/BaseControls/WPP/WPPPControl2015.mo
Outdated
Show resolved
Hide resolved
...o/sources/Models/Modelica/Dynawo/Electrical/Controls/IEC/BaseControls/WPP/WPPPControl2015.mo
Outdated
Show resolved
Hide resolved
dynawo/sources/Models/Modelica/Dynawo/Examples/Wind/IEC/Neplan/WPP4ACurrentSource2015.mo
Outdated
Show resolved
Hide resolved
dynawo/sources/Models/Modelica/Dynawo/Examples/Wind/IEC/Neplan/WPP4ACurrentSource2020.mo
Outdated
Show resolved
Hide resolved
dynawo/sources/Models/Modelica/Dynawo/Examples/Wind/IEC/Neplan/package.order
Show resolved
Hide resolved
dynawo/sources/Models/Modelica/PreassembledModels/IECWPP4ACurrentSource2015.xml
Show resolved
Hide resolved
dynawo/sources/Models/Modelica/PreassembledModels/IECWPP4BCurrentSource2015.xml
Outdated
Show resolved
Hide resolved
9648278
to
f9b3ea4
Compare
Signed-off-by: GARBAY Louis <garbaylou@gm0winl417.bureau.si.interne>
Signed-off-by: GARBAY Louis <garbaylou@gm0winl417.bureau.si.interne>
Signed-off-by: GARBAY Louis <garbaylou@gm0winl417.bureau.si.interne>
f9b3ea4
to
a14eee4
Compare
Placement(visible = true, transformation(origin = {110, -90}, extent = {{-10, -10}, {10, 10}}, rotation = 0))); | ||
Modelica.Blocks.MathBoolean.Or or1(nu = 2) annotation( | ||
Placement(visible = true, transformation(origin = {110, -40}, extent = {{10, -10}, {-10, 10}}, rotation = 0))); | ||
Dynawo.NonElectrical.Blocks.Continuous.TransferFunction transferFunction(a = {tpfv, 1}, b = {tpft, 1}, x_start = {-P0Pu * SystemBase.SnRef / SNom}, y_start = -P0Pu * SystemBase.SnRef / SNom) annotation( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you use the transfer function block of the Modelica library?
Placement(visible = true, transformation(origin = {-290, -40}, extent = {{-10, -10}, {10, 10}}, rotation = 0))); | ||
Dynawo.NonElectrical.Blocks.Continuous.AbsLimRateLimFeedthroughFreezeLimDetection absLimRateLimFeedthroughFreezeLimDetection1(DyMax = DXRefMaxPu, DyMin = DXRefMinPu, U0 = XWT0Pu, Y0 = XWT0Pu, YMax = XRefMaxPu, YMin = XRefMinPu, tS = tS) annotation( | ||
Placement(visible = true, transformation(origin = {326, 100}, extent = {{-10, -10}, {10, 10}}, rotation = 0))); | ||
Dynawo.NonElectrical.Blocks.Continuous.TransferFunction transferFunction(a = {txfv, 1}, b = {txft, 1}, x_start = {XWT0Pu}, y_start = XWT0Pu) annotation( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
<curvesInput xmlns="http://www.rte-france.com/dynawo"> | ||
<curve model="WPP4A" variable="WPP_wPPControl_measurements_PGenNomPu"/> | ||
<curve model="WPP4A" variable="WPP_wPPControl_measurements_QGenNomPu"/> | ||
<curve model="WPP4A" variable="WPP_wPPControl_measurements_UPu"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replace these three variables with the ones of 2015. For all the 2015 test cases
<curve model="WPP4A" variable="WPP_terminal_V_im"/> | ||
<curve model="WPP4A" variable="WPP_terminal_i_re"/> | ||
<curve model="WPP4A" variable="WPP_terminal_i_im"/> | ||
<curve model="WPP4A" variable="WPP_wT4ACurrentSource_gridProtection_fOCB"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could add also the timeline for this test case
<curve model="WPP4B" variable="WPP_terminal_V_im"/> | ||
<curve model="WPP4B" variable="WPP_terminal_i_re"/> | ||
<curve model="WPP4B" variable="WPP_terminal_i_im"/> | ||
<curve model="WPP4B" variable="WPP_wT4BCurrentSource_gridProtection_fOCB"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could also add timeline for this test case
Checklist before requesting a review
use
'[x]'
to check the checkboxes, or submit the PR and then click the checkboxes