Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3282 Update macro for test to avoid using same name as cmake built-i… #3285

Merged
merged 3 commits into from
Jun 20, 2024

Conversation

gautierbureau
Copy link
Member

…n function.

Checklist before requesting a review

use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes

  • unit tests and non-regression tests were added (new model, new feature and bug fix)
  • main documentation was updated (update of input/output file, 3rd party, model, repository organization, solver)
  • example documentations were updated (new example in examples folder)
  • the corresponding milestone was added in the ticket and in this PR
  • if this PR modifies the parameters or inputs/outputs of a model/solver: the corresponding xsl was added in util/xsl and platform DB were updated
  • if this PR modifies a dictionary: the corresponding french dictionary was updated

…n function.

Signed-off-by: Gautier Bureau <gautier.bureau@gmail.com>
Copy link
Contributor

@rosiereflo rosiereflo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok for me on public repo, don't we need an update in the private one?

@gautierbureau
Copy link
Member Author

ok for me on public repo, don't we need an update in the private one?

Yes it will come but they are independent on this so no synchro needed.

@rosiereflo rosiereflo merged commit 4b8b3e0 into master Jun 20, 2024
5 checks passed
@rosiereflo rosiereflo deleted the 3282_cmake_test_macro branch June 20, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename test macro to avoid using same name a cmake built-in
2 participants