Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File tomb, function lock_tomb_with_key(): Wrong comparison operator used to check a tomb's size #489

Closed
68420948 opened this issue Sep 25, 2023 · 0 comments · Fixed by #491

Comments

@68420948
Copy link

The operator < compares two strings lexicographically resulting in that a 100MB tomb is considered smaller than 47MB or 18MB.

Please consider this patch from Debian to fix the issue:
https://salsa.debian.org/pkg-security-team/tomb/-/blob/debian/master/debian/patches/comparison-operator.patch

Narrat pushed a commit to Narrat/Tomb that referenced this issue Sep 30, 2023
The operator < compares two strings lexicographically resulting in that a 100MB tomb is considered smaller than 47MB or 18MB.

Closes dyne#489
jaromil pushed a commit that referenced this issue Sep 30, 2023
The operator < compares two strings lexicographically resulting in that a 100MB tomb is considered smaller than 47MB or 18MB.

Closes #489
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant