Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added build target osx-lib to build an OSX static library. #94

Merged
merged 2 commits into from
Apr 20, 2020

Conversation

fdeantoni
Copy link
Contributor

To make development with Zenroom on OSX easier, I created a build target to create a static library for OSX. I'm not familiar with all clang build parameters, but so far the generated static library seems to work well in other projects (C, Rust).

Copy link
Member

@puria puria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @fdeantoni. You would also add the target to the docs https://github.com/DECODEproject/Zenroom/blob/master/docs/pages/how-to-build.md with a brief explaination? 🙏

@fdeantoni
Copy link
Contributor Author

Hi @puria, I can do that, but is seems to section on "static builds" is out of date as it mentions targets such as bootstrap, static, and check-static which I think dont exist anymore?

@puria
Copy link
Member

puria commented Apr 17, 2020

thanks @fdeantoni just added a separate issue to update the static targets as soon as we can (or if you also want to take care ;p). In the meantime you can go with the osx-lib, so I'll merge this PR.

@puria
Copy link
Member

puria commented Apr 18, 2020

@fdeantoni do you also have a concrete usage example? So we can put a super quick small test fixture (to run on the CI).

@fdeantoni
Copy link
Contributor Author

Hi @puria, the example I have is a small project to create Rust bindings for Zenroom, see here: zenroom.rs. Not sure if this is what you were looking for though. I created the osx-lib build target to make development of this library slightly easier (as I develop on OSX).

@puria
Copy link
Member

puria commented Apr 20, 2020

Enough then ;)

@puria puria merged commit e695abc into dyne:master Apr 20, 2020
@andrea-dintino
Copy link
Member

@fdeantoni thanks for the contribution! We have a channel about Zenroom on Telegram, you're most welcome to join: https://t.me/zenroom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants