Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lenscorrection needs interpolation #85

Open
pmjdebruijn opened this issue Oct 13, 2019 · 2 comments
Open

lenscorrection needs interpolation #85

pmjdebruijn opened this issue Oct 13, 2019 · 2 comments

Comments

@pmjdebruijn
Copy link

Currently it seems the lenscorrection filter does not use any interpolation (or well, effectively nearest neighbor???). This leads to clearly visible stairstepping artifacts which is especially noticable on scenes with clear geometric shapes at the edge of the frame.

It would be nice to have a interpolation=bilinear or interpolation=lanczos2 option available

It would also be nice for the lenscorrection filter to be able to apply an automatic "zoom", so the input resolution = output resolution without any green border visible.

@ddennedy
Copy link
Collaborator

Here you can see it was intended by its author but never completed:
https://github.com/dyne/frei0r/blob/master/src/filter/lenscorrection/lenscorrection.c#L211

@pmjdebruijn
Copy link
Author

Yeah I noticed that as well.

However, in the meantime I noticed defish0r too, which seems to be a good fit for my purposes, even though it technically doesn't support rectilinear lenses, it seemingly works well for mine.

defish0r also has choice of every common interpolator.

So adding proper rectilinear support to defish0r seems to make more sense now than adding interpolation to lenscorrection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants