Add common/arch-power.C

dyninst · Apr 3, 2024 · 1dfa972 · 1dfa972
1 parent 76c7942
commit 1dfa972
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 8 deletions.
diff --git a/common/src/arch-power.C b/common/src/arch-power.C
@@ -84,7 +84,6 @@ Dyninst::Address instruction::getTarget(Dyninst::Address addr) const {
     return 0;
 }
 
-// TODO: argument _needs_ to be an int, or ABS() doesn't work.
 void instruction::setBranchOffset(Dyninst::Address newOffset) {
     if (isUncondBranch()) {
         assert(ABS((int) newOffset) < MAX_BRANCH);
@@ -134,7 +133,6 @@ unsigned instruction::jumpSize(Dyninst::Address from, Dyninst::Address to, unsig
     return jumpSize(disp, addr_width);
 }
 
-// -1 is infinite, don't ya know.
 unsigned instruction::jumpSize(Dyninst::Address disp, unsigned addr_width) {
    if (ABS(disp) >= MAX_BRANCH) {
       return maxInterFunctionJumpSize(addr_width);
@@ -207,12 +205,6 @@ bool instruction::getUsedRegs(std::vector<int> &) {
 	return false;
 }
 
-// A thunk is a "get PC" operation. We consider
-// an instruction to be a thunk if it fulfills the following
-// requirements:
-//  1) It is unconditional or a "branch always" conditional
-//  2) It has an offset of 4
-//  3) It saves the return address in the link register
 bool instruction::isThunk() const {
   switch (BFORM_OP(*this)) {
   case Bop:

diff --git a/docs/common/developer/arch-power.h.rst b/docs/common/developer/arch-power.h.rst
@@ -30,6 +30,9 @@ arch-power.h
   .. cpp:function:: static unsigned size()
   .. cpp:function:: Dyninst::Address getBranchOffset() const
   .. cpp:function:: void setBranchOffset(Dyninst::Address newOffset)
+
+    TODO: argument *needs* to be an int, or ``ABS()`` doesn't work.
+
   .. cpp:function:: static unsigned jumpSize(Dyninst::Address from, Dyninst::Address to, unsigned addr_width)
   .. cpp:function:: static unsigned jumpSize(Dyninst::Address disp, unsigned addr_width)
   .. cpp:function:: static unsigned maxJumpSize(unsigned addr_width)