fix memory leaks

dyninst · Nov 24, 2016 · 3f6c943 · 3f6c943
1 parent 8849ea3
commit 3f6c943
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/symtabAPI/src/Collections.C b/symtabAPI/src/Collections.C
@@ -317,9 +317,14 @@ typeCollection::typeCollection() :
  */
 typeCollection::~typeCollection()
 {
-    // We sometimes directly delete (refcount == 1) or go through the
-    // decRefCount (which will delete when refcount == 0)
     // delete all of the types
+    for(const auto& t: typesByName) {
+        t.second->decrRefCount();
+    }
+
+    for(const auto& t: typesByID) {
+        t.second->decrRefCount();
+    }
 }
 
 /*

diff --git a/symtabAPI/src/Type.C b/symtabAPI/src/Type.C
@@ -210,8 +210,12 @@ void Type::incrRefCount()
 
 void Type::decrRefCount() 
 {
-	if (refCount > 0)
+	if (refCount > 1) {
 		refCount--;
+        } else {
+            delete this;
+        }
+
 }
 
 std::string &Type::getName()