Fix several resource leaks (#1435)

* Local var leak in Symtab::addSymbol

This was found using cppcheck's memleak.

* memCache::doOperation

Not technically a leak, but cppcheck can't see through the 'push_back'.

* PCProcess::hasPassedMain

Found using cppcheck's danglingTemporaryLifetime.

* parse_func::calcParentFunc

Found using cppcheck's danglingTemporaryLifetime.

* int_iRPC::setBinarySize

Found using cppcheck's publicAllocationError.

dyninstAPI/src/parse-power.C

@@ -94,7 +94,8 @@ std::string parse_func::calcParentFunc(const parse_func * imf,
   /* We need to figure out the function that called the outlined
      parallel region function.  We do this by chopping off the
      last @OL@number */
-   const char * nameStart = imf->prettyName().c_str();
+   auto const& tmp = imf->prettyName();
+   const char * nameStart = tmp.c_str();
    const char * nameEnd = strrchr(nameStart, '@');
    int strSize = nameEnd - nameStart - 3;
 

dyninstAPI/src/unix.C

@@ -530,11 +530,12 @@ bool PCProcess::hasPassedMain()
 bool PCProcess::startDebugger() {
     std::stringstream pidStr;
     pidStr << getPid();
+    auto tmp = pidStr.str();
 
     const char *args[4];
     args[0] = dyn_debug_crash_debugger;
     args[1] = file_.c_str();
-    args[2] = pidStr.str().c_str();
+    args[2] = tmp.c_str();
     args[3] = NULL;
 
     proccontrol_printf("%s[%d]: Launching %s %s %s\n", FILE__, __LINE__,

proccontrol/src/irpc.C

@@ -142,6 +142,7 @@ void int_iRPC::setBinarySize(unsigned long s)
 
 void int_iRPC::copyBinaryBlob(void *b, unsigned long s)
 {
+   if(binary_blob && freeBinaryBlob) free(binary_blob);
    binary_blob = malloc(s);
    assert(binary_blob);
    binary_size = s;

proccontrol/src/memcache.C

@@ -301,9 +301,7 @@ async_ret_t memCache::doOperation(memEntry *me, int_thread *op_thread)
       return aret_error;
    }
 
-   memEntry *me_copy = new memEntry(me, me->buffer);
-
-   mem_cache.push_back(me_copy);
+   mem_cache.push_back(new memEntry(me, me->buffer));
    last_operation = mem_cache.end();
    last_operation--;
 

symtabAPI/src/Symtab-edit.C

@@ -244,15 +244,15 @@ bool Symtab::addSymbol(Symbol *newSym, Symbol *referringSymbol)
         newSym->setReferringSymbol(referringSymbol);
 
         string filename = referringSymbol->getModule()->exec()->name();
-        vector<string> *vers, *newSymVers = new vector<string>;
+        vector<string> *vers{};
         newSym->setVersionFileName(filename);
         std::string rstr;
 
         newSym->getVersionFileName(rstr);
         if (referringSymbol->getVersions(vers) && vers != NULL && vers->size() > 0) 
         {
-            newSymVers->push_back((*vers)[0]);
-            newSym->setVersions(*newSymVers);
+            auto newSymVers = std::vector<std::string>{(*vers)[0]};
+            newSym->setVersions(newSymVers);
         }
     }else{
         newSym->setReferringSymbol(referringSymbol);