SymElf: fix memory leak of cached demangled names

* the existing cache in SymElf did not free the char* string in each cache entry
dyninst · Oct 21, 2020 · 464b24e · 464b24e
1 parent fd520f7
commit 464b24e
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/symlite/src/SymLite-elf.C b/symlite/src/SymLite-elf.C
@@ -102,6 +102,11 @@ SymElf::~SymElf()
       fd = -1;
    }
    if (cache) {
+      for (unsigned int i = 0; i < cache_size; ++i)  {
+         if (cache[i].demangled_name)  {
+            free(const_cast<char*>(cache[i].demangled_name));
+         }
+      }
       free(cache);
       cache = NULL;
       cache_size = 0;
@@ -366,9 +371,8 @@ std::string SymElf::getDemangledName(const Symbol_t &sym)
 
    if (cache[cache_index].demangled_name)
       return std::string(cache[cache_index].demangled_name);
-   //char *res = P_cplus_demangle(name, true);
-   std::string res = P_cplus_demangle(name, true);
 
+   std::string res = P_cplus_demangle(name, true);
    cache[cache_index].demangled_name = strdup(res.c_str());
    return cache[cache_index].demangled_name;
 }