Add proccontrol/src/unix.C

dyninst · Apr 3, 2024 · 464e279 · 464e279
1 parent 1fe4c84
commit 464e279
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/docs/proccontrol/developer/unix.h.rst b/docs/proccontrol/developer/unix.h.rst
@@ -18,6 +18,11 @@ unix.h
   .. cpp:function:: virtual bool plat_getMemoryAccessRights(Dyninst::Address addr, Process::mem_perm& rights)
   .. cpp:function:: virtual bool plat_setMemoryAccessRights(Dyninst::Address addr, size_t size, Process::mem_perm rights, Process::mem_perm& oldRights)
   .. cpp:function:: virtual bool plat_findAllocatedRegionAround(Dyninst::Address addr, Process::MemoryRegion& memRegion)
+
+    I'm not sure that unix_process is the proper place for this--it's really based on whether
+    ``/proc/PID/maps`` exists.  Currently, that matches our platforms that use unix_process, so I'll leave
+    it be for now.
+
   .. cpp:function:: virtual Dyninst::Address plat_mallocExecMemory(Dyninst::Address, unsigned size)
   .. cpp:function:: virtual bool plat_supportFork()
   .. cpp:function:: virtual bool plat_supportExec()
diff --git a/proccontrol/src/unix.C b/proccontrol/src/unix.C
@@ -251,9 +251,7 @@ bool unix_process::plat_findAllocatedRegionAround(Dyninst::Address addr,
     setLastError(err_unsupported, "Find Allocated Memory Region not supported on this platform\n");
     return false;
 }
-//I'm not sure that unix_process is the proper place for this--it's really based on whether
-// /proc/PID/maps exists.  Currently, that matches our platforms that use unix_process, so
-// I'll leave it be for now.
+
 Dyninst::Address unix_process::plat_mallocExecMemory(Dyninst::Address min, unsigned size) {
     Dyninst::Address result = 0x0;
     bool found_result = false;