Skip to content

Commit

Permalink
Remove unneeded assert
Browse files Browse the repository at this point in the history
  • Loading branch information
hainest committed Dec 21, 2023
1 parent 510f455 commit 4bcee51
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions instructionAPI/src/x86/decoder.C
Expand Up @@ -224,7 +224,7 @@ namespace Dyninst { namespace InstructionAPI {
Expression::Ptr effectiveAddr;
auto const isCFT = is_cft(insn->getCategory());
auto const isCall = is_call(insn->getCategory());
auto const isConditional = is_conditional(insn->getCategory(), insn->getOperation().getID());

// TODO: handle segment registers
if(operand.mem.base != X86_REG_INVALID) {
effectiveAddr = makeRegisterExpression(x86::translate_register(operand.mem.base, this->mode));
Expand All @@ -251,7 +251,6 @@ namespace Dyninst { namespace InstructionAPI {
else
memAST = makeDereferenceExpression(effectiveAddr, type);
if(isCFT) {
assert(!isConditional);
insn->addSuccessor(memAST, isCall, true, false, false);
} else {
// Capstone may report register operands as neither read nor written.
Expand Down

0 comments on commit 4bcee51

Please sign in to comment.