Add patchAPI/src/ParseCallback.C

dyninst · Apr 3, 2024 · 6256d62 · 6256d62
1 parent 0dcb097
commit 6256d62
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/docs/patchAPI/developer/ParseCallback.h.rst b/docs/patchAPI/developer/ParseCallback.h.rst
@@ -22,8 +22,15 @@ ParseCallback.h
   .. cpp:function:: protected virtual void add_edge_cb(ParseAPI::Block*, ParseAPI::Edge*, edge_type_t)
   .. cpp:function:: protected virtual void remove_block_cb(ParseAPI::Function*, ParseAPI::Block*)
   .. cpp:function:: protected virtual void add_block_cb(ParseAPI::Function*, ParseAPI::Block*)
+
+    Adds blocks lazily, basically does nothing unless block and function have already been created, in
+    which case it adds the block to the function.
+
   .. cpp:function:: protected virtual bool absAddr(Address absolute, Address& loadAddr, ParseAPI::CodeObject*& containerObject)
 
+    Returns the load address of the code object containing an absolute address.
+
+
 Notes
 =====
 

diff --git a/patchAPI/src/ParseCallback.C b/patchAPI/src/ParseCallback.C
@@ -196,8 +196,6 @@ void PatchParseCallback::remove_block_cb(ParseAPI::Function *func, ParseAPI::Blo
    pf->removeBlock(pb);
 }
 
-/* Adds blocks lazily, basically does nothing unless block and function have already
-   been created, in which case it adds the block to the function */
 void PatchParseCallback::add_block_cb(ParseAPI::Function *func, ParseAPI::Block *block) {
    PatchBlock *pb = _obj->getBlock(block, false);
    if (!pb) return; 
@@ -209,7 +207,6 @@ void PatchParseCallback::add_block_cb(ParseAPI::Function *func, ParseAPI::Block
    _obj->cb()->add_block(pf,pb);
 }
 
-// returns the load address of the code object containing an absolute address
 bool PatchParseCallback::absAddr(Address absolute, 
                                  Address & loadAddr, 
                                  ParseAPI::CodeObject *& codeObj)

diff --git a/patchAPI/src/ParseCallback.h b/patchAPI/src/ParseCallback.h
@@ -57,7 +57,6 @@ class PatchParseCallback : public ParseAPI::ParseCallback {
    virtual void remove_block_cb(ParseAPI::Function *, ParseAPI::Block *);
    virtual void add_block_cb(ParseAPI::Function *, ParseAPI::Block *);
 
-  // returns the load address of the code object containing an absolute address
   virtual bool absAddr(Address absolute, 
                        Address & loadAddr, 
                        ParseAPI::CodeObject *& containerObject);