Consolidate visibility control macros (#1738)

There is no need to have one per toolkit.

This also removes the MSVC-specific check because we don't build there
and we don't have any of the visibility compiler switches set for it,
either.

common/CMakeLists.txt

@@ -16,6 +16,7 @@ set(_public_headers
     h/dyn_regs.h
     h/dyn_syscalls.h
     h/dyntypes.h
+    h/dyninst_visibility.h
     h/Edge.h
     h/entryIDs.h
     h/Graph.h

common/h/Annotatable.h

@@ -50,8 +50,8 @@
 namespace Dyninst
 {
 
-COMMON_EXPORT bool annotation_debug_flag();
-COMMON_EXPORT int annotatable_printf(const char *format, ...)
+DYNINST_EXPORT bool annotation_debug_flag();
+DYNINST_EXPORT int annotatable_printf(const char *format, ...)
 	DYNINST_PRINTF_ANNOTATION(1, 2);
 
 typedef unsigned short AnnotationClassID;
@@ -60,7 +60,7 @@ typedef bool (*anno_cmp_func_t)(void *, void*);
 extern int newAnnotationClass();
 extern bool void_ptr_cmp_func(void *, void *);
 
-class COMMON_EXPORT AnnotationClassBase
+class DYNINST_EXPORT AnnotationClassBase
 {
    private:
       static std::vector<AnnotationClassBase *> *annotation_types;
@@ -127,9 +127,9 @@ typedef enum {
 	sp_rem_cont_item = 5
 } ser_post_op_t;
 
-COMMON_EXPORT const char *serPostOp2Str(ser_post_op_t);
+DYNINST_EXPORT const char *serPostOp2Str(ser_post_op_t);
 
-class COMMON_EXPORT AnnotatableDense
+class DYNINST_EXPORT AnnotatableDense
 {
 	typedef void *anno_list_t;
 
@@ -334,7 +334,7 @@ class COMMON_EXPORT AnnotatableDense
 
 #define AN_INLINE inline
 
-class COMMON_EXPORT AnnotatableSparse
+class DYNINST_EXPORT AnnotatableSparse
 {
    public:
       struct void_ptr_hasher

common/h/Buffer.h

@@ -48,7 +48,7 @@ namespace Dyninst {
 // Dyninst internal codeGen structure that aims to be more user-friendly. Tiers 2 and 3 
 // are TODO. 
 
-class COMMON_EXPORT Buffer {
+class DYNINST_EXPORT Buffer {
   public:
    Buffer(Address addr, unsigned initial_size);
    Buffer();

common/h/DynAST.h

@@ -163,7 +163,7 @@ class name : public AST {						\
   Children kids_;							\
  }									\
 
-class COMMON_EXPORT AST : public boost::enable_shared_from_this<AST> {
+class DYNINST_EXPORT AST : public boost::enable_shared_from_this<AST> {
  public:
 
   // This is a global list of all AST types, including those that are not
@@ -234,7 +234,7 @@ class COMMON_EXPORT AST : public boost::enable_shared_from_this<AST> {
   virtual bool isStrictEqual(const AST &rhs) const = 0;
 };
 
- class COMMON_EXPORT ASTVisitor {
+ class DYNINST_EXPORT ASTVisitor {
  public:
    typedef boost::shared_ptr<AST> ASTPtr;
 

common/h/Edge.h

@@ -42,7 +42,7 @@ namespace Dyninst {
 class Graph;
 class Node;
 
-class COMMON_EXPORT Edge : public AnnotatableSparse {
+class DYNINST_EXPORT Edge : public AnnotatableSparse {
     friend class Node;
     friend class Graph;
     friend class Creator;
@@ -82,7 +82,7 @@ class COMMON_EXPORT Edge : public AnnotatableSparse {
 
  class EdgeIteratorImpl;
 
-class COMMON_EXPORT EdgeIterator {
+class DYNINST_EXPORT EdgeIterator {
     friend class Node;
     friend class Graph;
     friend class Edge;

common/h/Graph.h

@@ -55,7 +55,7 @@ class Node;
 class NodeIterator;
 class EdgeIterator;
 
-class COMMON_EXPORT Graph : public AnnotatableSparse {
+class DYNINST_EXPORT Graph : public AnnotatableSparse {
     friend class Edge;
     friend class Node;
     friend class Creator;

common/h/MachSyscall.h

@@ -38,7 +38,7 @@ namespace ProcControlAPI
     MachSyscall makeFromID(boost::shared_ptr<Process> proc, unsigned long id);
 }
 
-class COMMON_EXPORT MachSyscall 
+class DYNINST_EXPORT MachSyscall 
 {
     public: 
         typedef unsigned long SyscallIDPlatform;

common/h/Node.h

@@ -52,7 +52,7 @@ class Graph;
 class NodeIterator;
 class EdgeIterator;
 
-class COMMON_EXPORT Node  {
+class DYNINST_EXPORT Node  {
     friend class Edge;
     friend class Graph;
 
@@ -114,7 +114,7 @@ class COMMON_EXPORT Node  {
     static const Address INVALID_ADDR;
 };
 
-class COMMON_EXPORT PhysicalNode : public Node {
+class DYNINST_EXPORT PhysicalNode : public Node {
 public:
 	typedef boost::shared_ptr<PhysicalNode> Ptr;
 
@@ -136,7 +136,7 @@ class COMMON_EXPORT PhysicalNode : public Node {
     Address addr_; 
 };
 
-class  COMMON_EXPORT VirtualNode : public Node {
+class  DYNINST_EXPORT VirtualNode : public Node {
     friend class Edge;
     friend class Graph;
 
@@ -166,7 +166,7 @@ class  COMMON_EXPORT VirtualNode : public Node {
 
  class NodeIteratorImpl;
 
-class COMMON_EXPORT NodeIterator {
+class DYNINST_EXPORT NodeIterator {
     friend class Node;
     friend class Graph;
     friend class Edge;

common/h/SymReader.h

@@ -82,7 +82,7 @@ struct SymSegment {
  * that the underlying implementation could be made re-enterant safe (so it 
  * could be called from a signal handler).
  **/
-class COMMON_EXPORT SymReader
+class DYNINST_EXPORT SymReader
 {
  protected:
    SymReader() {}
@@ -123,7 +123,7 @@ class COMMON_EXPORT SymReader
 
 };
 
-class COMMON_EXPORT SymbolReaderFactory
+class DYNINST_EXPORT SymbolReaderFactory
 {
  public:
    SymbolReaderFactory() {}

common/h/VariableLocation.h

@@ -52,7 +52,7 @@ typedef enum {
    storageRegOffset
 } storageClass;
 
-COMMON_EXPORT const char *storageClass2Str(storageClass sc);
+DYNINST_EXPORT const char *storageClass2Str(storageClass sc);
 
 /*
  * storageRefClass: Encodes if a variable can be accessed through a register/address.
@@ -66,7 +66,7 @@ typedef enum {
    storageNoRef
 } storageRefClass;
 
-COMMON_EXPORT const char *storageRefClass2Str(storageRefClass sc);
+DYNINST_EXPORT const char *storageRefClass2Str(storageRefClass sc);
 
 //location for a variable
 //Use mr_reg instead of reg for new code.  reg left in for backwards

common/h/concurrent.h

@@ -47,12 +47,12 @@
 namespace Dyninst {
 
 namespace dyn_c_annotations {
-    void COMMON_EXPORT rwinit(void*);
-    void COMMON_EXPORT rwdeinit(void*);
-    void COMMON_EXPORT wlock(void*);
-    void COMMON_EXPORT wunlock(void*);
-    void COMMON_EXPORT rlock(void*);
-    void COMMON_EXPORT runlock(void*);
+    void DYNINST_EXPORT rwinit(void*);
+    void DYNINST_EXPORT rwdeinit(void*);
+    void DYNINST_EXPORT wlock(void*);
+    void DYNINST_EXPORT wunlock(void*);
+    void DYNINST_EXPORT rlock(void*);
+    void DYNINST_EXPORT runlock(void*);
 }
 
 namespace concurrent {
@@ -207,7 +207,7 @@ class dyn_mutex : public boost::mutex {
     using unique_lock = boost::unique_lock<dyn_mutex>;
 };
 
-class COMMON_EXPORT dyn_rwlock {
+class DYNINST_EXPORT dyn_rwlock {
     // Reader management members
     boost::atomic<unsigned int> rin;
     boost::atomic<unsigned int> rout;
@@ -234,7 +234,7 @@ class COMMON_EXPORT dyn_rwlock {
     using shared_lock = boost::shared_lock<dyn_rwlock>;
 };
 
-class COMMON_EXPORT dyn_thread {
+class DYNINST_EXPORT dyn_thread {
 public:
     dyn_thread();
     unsigned int getId();

common/h/dyninst_visibility.h

@@ -0,0 +1,36 @@
+/*
+ * See the dyninst/COPYRIGHT file for copyright information.
+ *
+ * We provide the Paradyn Tools (below described as "Paradyn")
+ * on an AS IS basis, and do not warrant its validity or performance.
+ * We reserve the right to update, modify, or discontinue this
+ * software at any time.  We shall have no obligation to supply such
+ * updates or modifications or any other form of support to you.
+ *
+ * By your use of Paradyn, you understand and agree that we (or any
+ * other person or entity with proprietary rights in Paradyn) are
+ * under no obligation to provide either maintenance services,
+ * update services, notices of latent defects, or correction of
+ * defects for Paradyn.
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2.1 of the License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+ */
+
+#ifndef DYNINST_COMMON_DYNINST_VISIBILITY_H
+#define DYNINST_COMMON_DYNINST_VISIBILITY_H
+
+#define DYNINST_EXPORT __attribute__((visibility ("default")))
+
+#endif

common/h/entryIDs.h

@@ -56,8 +56,8 @@ enum prefixEntryID : unsigned int {
 };
 
 namespace NS_x86 {
-COMMON_EXPORT extern dyn_hash_map<entryID, std::string> entryNames_IAPI;
-COMMON_EXPORT extern dyn_hash_map<prefixEntryID, std::string> prefixEntryNames_IAPI;
+DYNINST_EXPORT extern dyn_hash_map<entryID, std::string> entryNames_IAPI;
+DYNINST_EXPORT extern dyn_hash_map<prefixEntryID, std::string> prefixEntryNames_IAPI;
 }
 
 #endif

common/h/registers/MachRegister.h

@@ -41,7 +41,7 @@
 namespace Dyninst {
   typedef unsigned long MachRegisterVal;
 
-  class COMMON_EXPORT MachRegister {
+  class DYNINST_EXPORT MachRegister {
   private:
     int32_t reg;
 

common/h/registers/reg_def.h

@@ -54,11 +54,11 @@
 // const.
 #  define DEF_REGISTER(name, value, Arch)                                                          \
     const signed int i##name = (value);                                                            \
-    COMMON_EXPORT MachRegister name(i##name, Arch "::" #name)
+    DYNINST_EXPORT MachRegister name(i##name, Arch "::" #name)
 #else
 #  define DEF_REGISTER(name, value, Arch)                                                          \
     const signed int i##name = (value);                                                            \
-    COMMON_EXPORT extern MachRegister name
+    DYNINST_EXPORT extern MachRegister name
 
 #endif