Move setting of CMAKE_BUILD_TYPE to base CMakeLists.txt

This keeps all CMake-level variables in one place.
dyninst · Dec 22, 2022 · 9f1ece4 · 9f1ece4
1 parent fa518b7
commit 9f1ece4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 11 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -20,6 +20,10 @@ project(
     HOMEPAGE_URL "https://github.com/dyninst/dyninst"
     LANGUAGES C CXX ASM)
 
+if(NOT CMAKE_BUILD_TYPE)
+    set(CMAKE_BUILD_TYPE RelWithDebInfo)
+endif()
+
 set(DYNINST_ROOT ${PROJECT_SOURCE_DIR})
 set(CMAKE_SKIP_BUILD_RPATH FALSE)
 set(CMAKE_BUILD_WITH_INSTALL_RPATH FALSE)

diff --git a/cmake/DyninstLibrary.cmake b/cmake/DyninstLibrary.cmake
@@ -112,14 +112,3 @@ if(PLATFORM MATCHES nt OR PLATFORM MATCHES windows)
         add_definitions(-Dsnprintf=_snprintf)
     endif()
 endif()
-
-
-# set default configuration type
-
-if(NOT CMAKE_BUILD_TYPE)
-    set(CMAKE_BUILD_TYPE
-        RelWithDebInfo
-        CACHE STRING
-              "Choose the build type (None, Debug, Release, RelWithDebInfo, MinSizeRel)"
-              FORCE)
-endif()