Remove deprecated BPatch_regExpr (#838)

This was deprecated by 4d15de8 in 2008.

dyninstAPI/h/BPatch_snippet.h

@@ -255,16 +255,6 @@ class BPATCH_DLL_EXPORT BPatch_whileExpr : public BPatch_snippet {
                     const BPatch_snippet &body);
 };
 
-class BPATCH_DLL_EXPORT BPatch_regExpr : public BPatch_snippet {
- public:
-    // DEPRECATED!!!
-
-    //  BPatch_regExpr::BPatch_regExpr
-    //  Creates a representation of the contents of a particular register
-    //  specified by <value>
-    BPatch_regExpr(unsigned int value);
-};
-
 class BPATCH_DLL_EXPORT BPatch_funcCallExpr : public BPatch_snippet {
  public:
     //  BPatch_funcCallExpr::BPatch_funcCallExpr

dyninstAPI/src/BPatch_snippet.C

@@ -725,33 +725,6 @@ BPatch_whileExpr::BPatch_whileExpr(const BPatch_snippet &conditional,
    ast_wrapper->setTypeChecking(BPatch::bpatch->isTypeChecked());
 }
 
-/*
- * BPatch_regExpr::BPatch_regExpr
- *
- * Constructs a snippet representing a register.
- *
- * value        index of register.
- *
- * Note:  introduced for paradyn-seperation (paradyn needs access
- *        to register REG_MT_POS)  -- there are other ways to do this.
- *        This happens to be expedient -- not sure if we want to be
- *        really exposing this to API users.  Thus this class may be
- *        temporary -- avoid using it.
- */
-
-BPatch_regExpr::BPatch_regExpr(unsigned int value)
-{
-    ast_wrapper = AstNodePtr(AstNode::operandNode(AstNode::DataReg, (void *)(unsigned long int) value));
-
-    assert(BPatch::bpatch != NULL);
-    ast_wrapper->setTypeChecking(BPatch::bpatch->isTypeChecked());
-
-    BPatch_type *type = BPatch::bpatch->stdTypes->findType("long");
-    assert(type != NULL);
-
-    ast_wrapper->setType(type);
-}
-
 /*
  * BPatch_funcCallExpr::BPatch_funcCallExpr
  *