UPdate common/h/Architecture.h

dyninst · Apr 3, 2024 · ee24dd7 · ee24dd7
1 parent 4971d07
commit ee24dd7
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 10 deletions.
diff --git a/common/h/Architecture.h b/common/h/Architecture.h
@@ -35,20 +35,19 @@
 
 namespace Dyninst {
 
-  // 0xff000000 is used to encode architecture
   typedef enum {
     Arch_none = 0x00000000,
     Arch_x86 = 0x14000000,
     Arch_x86_64 = 0x18000000,
     Arch_ppc32 = 0x24000000,
     Arch_ppc64 = 0x28000000,
-    Arch_aarch32 = 0x44000000, // for later use
+    Arch_aarch32 = 0x44000000,
     Arch_aarch64 = 0x48000000,
     Arch_cuda = 0x88000000,
-    Arch_amdgpu_gfx908 = 0x94000000, // future support for gfx908
-    Arch_amdgpu_gfx90a = 0x98000000, // future support for gfx90a
-    Arch_amdgpu_gfx940 = 0x9c000000, // future support for gfx940
-    Arch_intelGen9 = 0xb6000000      // same as machine no. retrevied from eu-readelf
+    Arch_amdgpu_gfx908 = 0x94000000,
+    Arch_amdgpu_gfx90a = 0x98000000,
+    Arch_amdgpu_gfx940 = 0x9c000000,
+    Arch_intelGen9 = 0xb6000000
   } Architecture;
 
   inline unsigned getArchAddressWidth(Architecture arch) {

diff --git a/docs/common/public/Architecture.h.rst b/docs/common/public/Architecture.h.rst
@@ -42,20 +42,22 @@ Architecture.h
 
   .. cpp:enumerator:: Arch_amdgpu_gfx908
 
-    AMD GPU gfx908
+     Future support for AMD GPU gfx908
 
   .. cpp:enumerator:: Arch_amdgpu_gfx90a
 
-    AMD GPU gfx90a
+    Future support for AMD GPU gfx90a
 
   .. cpp:enumerator:: Arch_amdgpu_gfx940
 
-    AMD GPU gfx940
+    Future support for AMD GPU gfx940
 
   .. cpp:enumerator:: Arch_intelGen9
 
     Intel 9th Generation Graphics Technology (Apollo Lake)
 
+    Same as machine number retrevied from eu-readelf.
+
 .. cpp:function:: inline unsigned getArchAddressWidth(Architecture arch)
 
-    Returns the number of bits used to make a memory address
+  Returns the number of bits used to make a memory address