symtabAPI: Apply corrections for the library_adjust page offset #109
Conversation
This commit aggregates the incremental fixes that Bill Williams and I found while investigating issue dyninst#93, rewriting libc.so. - The offsets of new sections need to account for library_adjust when placing themselves after the first new section. - TLS symbol values need *not* be adjusted, as they're section-relative. - DT_INIT/FINI values need to be adjusted. - x86 IRELATIVE relocations need their addends adjusted. Fixes dyninst#93.
|
What, other than the libc test case, is already verified, and what's on tomorrow's TODO for me? |
|
I've made sure that everything in the libc-sampler I offered before now works, both as a standalone program and with Also, all of the rewriter tests pass on Fedora 24 x86_64, except for If you have ppc readily available, that probably deserves testing too. There may be more arch-specific papercuts lingering. |
|
I do have ppc readily available, but it's behaving quite oddly (see #34 for details). That said, it was producing binaries that execute IIRC for both pic and non-pic, and I can sanity check that much at least. RHEL6 should be boring but I'm about to confirm that. |
This commit aggregates the incremental fixes that Bill Williams and I
found while investigating issue #93, rewriting libc.so.
placing themselves after the first new section.
Fixes #93.