-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add interface for getting undefined function and variable info #1245
base: kupsch/parse-callsites-preview-3
Are you sure you want to change the base?
Add interface for getting undefined function and variable info #1245
Conversation
@mplegendre you need to rebase with dyninst master, you are missing the ABI tests!
The testing suite has been pretty actively changed so it's going to likely influence results here. |
I'm merging into @kupsch's callsite branch, not master. It's building on that work, and I don't want to rush the callsite work into master before it's ready. |
@mplegendre if we are going to use this in Smeagle, could you provide some documentation for the functions that should be used and replaced? |
@mplegendre, @vsoch there is now a branch kupsch/parse-callsites-preview-3 that is based on the tip of master. Rebase your branch to it, and the test problems should be fixed |
woot! Thank you @kupsch ! |
@mplegendre the libabigail ABI tests are super baller you will like them. |
daf7f61
to
6092f6f
Compare
I've rebased to parse-callsites-preview-3. That fixed the testsuite problems I was having. |
Tests are running here (I changed the recipe so they would! #1247) |
As discussed, I've added an interface for fetching information about undefined functions and variables without going through Function callsite info. This builds off of @kupsch work on callsites, but helps with some situations with compilers (seen in gcc 10.2) aren't outputting callsite DWARF information, but they are outputting signatures for undefined symbols. This works by building up a list of undefined symbol names from the GOT, then when DWARF parsing it matches Type and Function signature info to those symbol names.
I was unable to get the Dyninst testsuite working, and I've only validated this against some out-of-testsuite tests.