Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect format string in Result.h for u48 / s48 / u64 / s64 #1311

Merged
merged 1 commit into from
Oct 26, 2022
Merged

Fix incorrect format string in Result.h for u48 / s48 / u64 / s64 #1311

merged 1 commit into from
Oct 26, 2022

Conversation

bbiiggppiigg
Copy link
Collaborator

@bbiiggppiigg bbiiggppiigg commented Oct 24, 2022 •
edited by hainest

Fixes #1310

@hainest
Copy link
Contributor

hainest commented Oct 24, 2022

Ha! Looks like I broke this aeons ago: 7e6b768. How did I miss the hex conversion? It should definitely be fixed. I do hate the printf family, but it's the best solution we have unless/until we use fmt.

@hainest hainest merged commit bedbd67 into master Oct 26, 2022
@bbiiggppiigg bbiiggppiigg deleted the fix_immediate_formatting branch October 3, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hainest hainest hainest approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

InstructionAPI Result type outputs wrong format string on certain types
2 participants
@bbiiggppiigg @hainest