Manually add hex prefix when formatting an Operand #1313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbiiggppiigg
added
bug
instructionAPI
hainest
approved these changes
Oct 26, 2022
kupsch
reviewed
Oct 26, 2022
I was going to recommend that, but it looks like it doesn't append the prefix when the value is zero. A quick grep found that other usages manually prepend the "0x". I don't know if it that is to handle the zero case or just from copy/paste. |
|
If you want "0x0" then leave the code as is. If just "0" is acceptable then use the '#' modifier. I could see either case being acceptable. |
hainest
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this is a misuse of snprintf format string.
Instead of outputting the numeric value in hex, it would output the value as dec followed by a literal x which makes no sense at all.