use default allocator for tbb::concurrent_hash_map #1332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kupsch
added
ABI-BREAKER
|
This would probably be silenced by adding SYSTEM to the target_include_directories for the TBB headers |
|
Thanks, we already have that in the pipeline and it does silence the warning. We are also removing the default as it did nothing and for a future change to the scalable allocator. |
hainest
approved these changes
Dec 19, 2022
- gcc 12 warns about mismatched new and delete when an allocator is specified This is likely a false positive. Change to use the default, which uses ends up using the same std C++ new allocator
kupsch
force-pushed
the
kupsch/fix-gcc-12-warnings-tbb-concurrent_hash_map
branch
from
c565849
to
2ed77ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes warning produced by gcc 12: a non-default allocator for tbb::concurrent_hash_map causes a new/delete mismatch warning (that appears to be a false positive). Warning produced since tbb headers are not marked as a system headers yet.
In the future the allocator should be changed to use the tbb scalable allocator.
Related to #1331