Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing include file #1344

Merged
merged 1 commit into from
Jan 5, 2023
Merged

Conversation

kupsch
Copy link
Contributor

@kupsch kupsch commented Dec 20, 2022

  • add missing #include

    On more platforms and library combinations is included via some other header, but there is combination where this is not true

- add missing #include <deque>

  On more platforms and library combinations <deque> is included via
  some other header, but there is combination where this is not true
@kupsch kupsch added the build label Dec 20, 2022
@kupsch kupsch requested a review from hainest December 20, 2022 16:55
@kupsch kupsch self-assigned this Dec 20, 2022
@hainest
Copy link
Contributor

hainest commented Dec 20, 2022

I was actually just putting a PR together for this. I am also seeing missing include of std::array here and time.h in the testsuite. I'll make a PR for that last one.

diff --git a/dataflowAPI/src/AbslocInterface.C b/dataflowAPI/src/AbslocInterface.C
index 9d7ad000c..90a6113d6 100644
--- a/dataflowAPI/src/AbslocInterface.C
+++ b/dataflowAPI/src/AbslocInterface.C
@@ -44,6 +44,7 @@
 #include "common/src/singleton_object_pool.h"
 #include "parseAPI/h/CFG.h"
 #include "parseAPI/h/CodeObject.h"
+#include <deque>
 
 using namespace Dyninst;
 using namespace Dyninst::InstructionAPI;
diff --git a/instructionAPI/src/AMDGPU/cdna2/InstructionDecoder-amdgpu-cdna2.h b/instructionAPI/src/AMDGPU/cdna2/InstructionDecoder-amdgpu-cdna2.h
index d35482ffa..e90cdf2b3 100644
--- a/instructionAPI/src/AMDGPU/cdna2/InstructionDecoder-amdgpu-cdna2.h
+++ b/instructionAPI/src/AMDGPU/cdna2/InstructionDecoder-amdgpu-cdna2.h
@@ -32,6 +32,7 @@
 #include <iostream>
 #include "Immediate.h"
 #include "dyn_regs.h"
+#include <array>
 
 namespace Dyninst {
     namespace InstructionAPI {
diff --git a/instructionAPI/src/AMDGPU/vega/InstructionDecoder-amdgpu-vega.h b/instructionAPI/src/AMDGPU/vega/InstructionDecoder-amdgpu-vega.h
index e263f5c93..5fc894cde 100644
--- a/instructionAPI/src/AMDGPU/vega/InstructionDecoder-amdgpu-vega.h
+++ b/instructionAPI/src/AMDGPU/vega/InstructionDecoder-amdgpu-vega.h
@@ -32,6 +32,7 @@
 #include <iostream>
 #include "Immediate.h"
 #include "dyn_regs.h"
+#include <array>
 
 namespace Dyninst {
     namespace InstructionAPI {
diff --git a/instructionAPI/src/InstructionDecoder-aarch64.h b/instructionAPI/src/InstructionDecoder-aarch64.h
index 7994d0b1c..6f665e7ed 100644
--- a/instructionAPI/src/InstructionDecoder-aarch64.h
+++ b/instructionAPI/src/InstructionDecoder-aarch64.h
@@ -32,6 +32,7 @@
 #include <iostream>
 #include "Immediate.h"
 #include "dyn_regs.h"
+#include <array>
 
 namespace Dyninst {
     namespace InstructionAPI {

@kupsch kupsch merged commit 2e3bf92 into dyninst:master Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants