Update global ctor/dtor instrumentation for static executables #1355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hainest
added
bug
dyninstAPI_RT
|
This is just for x86. I'll update ARM and ppc once I test this. |
kupsch
approved these changes
Jan 27, 2023
hainest
force-pushed
the
glibc_elf_constructors
branch
from
6896ff0
to
c6f6345
Compare
If __libc_csu_init doesn't exist, try to insert the constructor call into the beginning of 'main'.
This just saves a bit of unneeded computation.
hainest
force-pushed
the
glibc_elf_constructors
branch
from
c6f6345
to
08854e6
Compare
There's no need to have a std::string object that incurs the overhead of a constructor/destructor call to just hold a literal that's only visible in the current translation unit.
It's the C++ way.
|
Testing fine all all platforms. |
|
@kupsch Could you take a quick pass over this? It's testing fine, but I want to make sure I didn't do something stupid. |
kupsch
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
glibc-2.34 removed __libc_csu_init(fini) which was used as instrumentation points for Dyninst's global constructor(destructor). We now insert the global Dyninst constructor into the beginning of 'main' and the global destructor into the beginning of 'exit'.