Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update spack.yaml for spack v0.19.1 #1367

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

weixiao-zhan
Copy link
Contributor

@weixiao-zhan weixiao-zhan commented Feb 13, 2023

@vsoch
Copy link
Contributor

vsoch commented Feb 13, 2023

It looks like the automated build was disabled - @hainest you might want to test this locally to make sure the new spack builds (can't assume that it does!)

@weixiao-zhan weixiao-zhan deleted the origin-master-docker branch February 14, 2023 17:22
@weixiao-zhan weixiao-zhan restored the origin-master-docker branch February 15, 2023 23:16
@weixiao-zhan weixiao-zhan reopened this Feb 15, 2023
@hainest
Copy link
Contributor

hainest commented Feb 16, 2023

@weixiao-zhan How are you building Dyninst that you ran into this? I disabled these builds because I was tired of chasing spack and our rate of change was small enough that local builds were fine.

@weixiao-zhan
Copy link
Contributor Author

Yes, I was rebuilding Dyninst from the latest master branch (I was previously using v12.1.0, and I wanted to make sure the ENDBR patch works with the latest code). As mentioned in issue #1365 , I changed the yaml following their doc. Before spack changes their commands again, this should work.

@hainest
Copy link
Contributor

hainest commented Feb 16, 2023

Ok. If it's working for you, then it's fine to merge. If you could 'Squash and Merge' that would be great.

@weixiao-zhan weixiao-zhan merged commit 54320d4 into dyninst:master Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dockerfile spack.yaml property error
3 participants