New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Github CI #1393
Merged
Merged
Update Github CI #1393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hainest
force-pushed
the
thaines/docker_refactor
branch
from
March 4, 2023 07:19
ea0fc2e
to
1f861f5
Compare
This will be done in the CI workflow instead.
The testsuite doesn't run on Github CI because... reasons.
The release process will (eventually) be a copy of the container created by the Dockerfile. In essence, just a regular Dyninst image but at a fixed version.
This reflects its new purpose
It better reflects what's happening
There's no need for it to be a specific version.
If someone forks our repo, they can re-write the workflows if they want them to work for their fork.
This is only ever run when we push to master, so the checks are redundant.
hainest
force-pushed
the
thaines/docker_refactor
branch
from
March 14, 2023 20:41
a9a0e6c
to
1686fb5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run on pull request to master:
Run on push to master: