Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uninitialized member variables #1431

Merged
merged 1 commit into from May 10, 2023
Merged

Fix uninitialized member variables #1431

merged 1 commit into from May 10, 2023

Conversation

hainest
Copy link
Contributor

@hainest hainest commented May 10, 2023

These were detected by cppcheck's uninitMemberVar*. No attempt was made to be consistent in solving each item. Some are directly initialized in the class declaration, others have modified constructor initializer lists.

@kupsch I'll take a careful look over these once the CI runs to see if there are any enum members that should have better defaults.

These were detected by cppcheck's uninitMemberVar*.
@hainest hainest added the bug label May 10, 2023
@hainest hainest requested a review from kupsch May 10, 2023 05:14
@hainest hainest self-assigned this May 10, 2023
@hainest
Copy link
Contributor Author

hainest commented May 10, 2023

@kupsch I've verified these and found no needed changes.

@hainest hainest merged commit f0c88be into master May 10, 2023
2 checks passed
@hainest hainest deleted the fix_uninit_member_var branch May 10, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants